Code review comment for lp:~ddormer/kali/kali-update

Revision history for this message
Tristan Seligmann (mithrandi) wrote :

Having manually assigned CIDs for every pseudouser seems rather error-prone; it's too easy to accidentally use the same CID in two places, especially in the scenario where we eventually can have Kali plugins from external packages.

What about having a method on the controller to return a new CID instead? It can allocate them sequentially, the same way InspIRCd apparently does it, so that can be done when the pseudouser is being broadcast thus avoiding any possibility of collisions.

review: Needs Fixing

« Back to merge proposal