Merge lp:~dcraven/quickly/add-quickly_editor into lp:quickly

Proposed by Dennis Craven
Status: Merged
Merged at revision: 552
Proposed branch: lp:~dcraven/quickly/add-quickly_editor
Merge into: lp:quickly
Diff against target: 15 lines (+3/-0)
1 file modified
data/templates/ubuntu-application/internal/quicklyutils.py (+3/-0)
To merge this branch: bzr merge lp:~dcraven/quickly/add-quickly_editor
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+38337@code.launchpad.net

Description of the change

I use different text editors for different things. For quick edits I use what $EDITOR and sensible-editor define. When I code, I prefer a different editor. Currently "quickly edit" uses $EDITOR if it's defined.

This branch adds the use of $QUICKLY_EDITOR so that this option can be overridden. If $QUICKLY_EDIT is defined, it is honored. Otherwise execution proceeds as usual. It's a trivial change, and not critical, but might be useful for others like myself.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks for your work there :)

Yeah, sounds like a good idea. approved!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/templates/ubuntu-application/internal/quicklyutils.py'
2--- data/templates/ubuntu-application/internal/quicklyutils.py 2010-10-07 14:54:39 +0000
3+++ data/templates/ubuntu-application/internal/quicklyutils.py 2010-10-13 18:39:06 +0000
4@@ -241,10 +241,13 @@
5
6 editor = "gedit"
7 default_editor = os.environ.get("EDITOR")
8+ quickly_editor = os.environ.get("QUICKLY_EDITOR")
9 if not default_editor:
10 default_editor = os.environ.get("SELECTED_EDITOR")
11 if default_editor:
12 editor = default_editor
13+ if quickly_editor:
14+ editor = quickly_editor
15 return editor
16
17

Subscribers

People subscribed via source and target branches