Code review comment for lp:~dcaro/clicompanion/fix-910355

Revision history for this message
Marek BardoĊ„ski (bdfhjk) wrote :

I checked Clicompanion both statically and dynamically. No errors in code observed.

    Bug #611141: It is not obvious that "q" must be pressed to exit help (man pages) [OK]

    Bug #801906: clicompanion crashes on start with ValueError in _get() [Look good]

    Bug #909894: Double click execution with user input drags command [OK]

    Bug #910249: Warning window (when wrong params issued) not working properly [OK]

    Bug #910355: Properties are not applied to the current terminal [OK]

    Bug #910360: Incorrect .clicompanion2 file causes the program to crash [OK]

    Bug #910370: Drag and drop when searching breaks the drag and drop [OK]

    Bug #910531: Allowed empty user input [OK]

    Bug #910533: In a fresh start, when executting the first command, the second gets executed instead [OK]

Regression bugs:
1. Low importance. Everytime, when I open new instance of Clicompanion, I got a message "INFO: Created config file at /home/user/.config/clicompanion/config", but that isn't true - my configuration is stored correctly and no new file was created.

Thank You for your work.

review: Approve

« Back to merge proposal