Merge lp:~dcaro/clicompanion/fix-896432 into lp:~clicompanion-devs/clicompanion/debian

[David Caro]

Added the gtk2-engines-pixbuf dependency, also removed the most dependency.

[Marek Bardoński (bdfhjk)]

Do You know, where this lib is used? Maybe it isn't necessary.

review: Needs Information

[David Caro (dcaro)]

It's not directly used by clicompanion, but by gtk itself, it's installed
by default on natty at least. I'm not sure if it has something to do but we
use pixbufs on the icons, also If you remove the package the warning shows
up again (maybe it's related with the theme engine used, but in the default
it's needed).

Anyway, I have not noticed if something is missing when the pa ckage is not
installed...

David
El 13/01/2012 16:31, "Marek Bardoński" <email address hidden> escribió:

> Review: Needs Information
>
> Do You know, where this lib is used? Maybe it isn't necessary.
> --
> https://code.launchpad.net/~dcaro/clicompanion/fix-896432/+merge/88426
> You are the owner of lp:~dcaro/clicompanion/fix-896432.
>

[David Caro (dcaro)]

On ubuntu 11.10 those packages depend on gtk2-engines-pixbuf:
Reverse Depends:
  xubuntu-desktop,gtk2-engines-pixbuf
  xubuntu-desktop,gtk2-engines-pixbuf
  ubuntu-sugar-remix,gtk2-engines-pixbuf
  python-poker2d,gtk2-engines-pixbuf
  oxygen-molecule,gtk2-engines-pixbuf
  openshot,gtk2-engines-pixbuf
  lxdm,gtk2-engines-pixbuf
  gtk2-engines-mythbuntu,gtk2-engines-pixbuf
  gtk2-engines-blueheart,gtk2-engines-pixbuf
  gnome-themes-ubuntu,gtk2-engines-pixbuf
  gnome-themes-selected,gtk2-engines-pixbuf
  gnome-themes-more,gtk2-engines-pixbuf
  gnome-themes,gtk2-engines-pixbuf
  audacious,gtk2-engines-pixbuf

Then I suppose that if you have regular ubuntu (not kubuntu) you have the package already installed (that's why we haven't noticed this before), so I guess that we need it installed, but not sure why.. (terminator for example also shows this warning when this package is not installed).

Tested also a little more, and evrerything seems to work fine without the package, so I'm not sure if this affects the usability of the program.

[Marek Bardoński (bdfhjk)]

Ok.

Thank You!

review: Approve

[Duane Hinnen (duanedesign)]

review: Approve

[Marek Bardoński (bdfhjk)]

review: Approve

=== modified file 'control'
--- control	2011-11-10 11:21:56 +0000
+++ control	2012-01-15 21:22:35 +0000
@@ -14,7 +14,7 @@
 
 Package: clicompanion
 Architecture: all
-Depends: ${misc:Depends}, ${python:Depends}, most, python-vte, python-gtk2
+Depends: ${misc:Depends}, ${python:Depends}, python-vte, python-gtk2, gtk2-engines-pixbuf
 Description: run terminal commands from a GUI storing commands for later use
  CLI Companion is an application that is used as a complement to the Terminal.
  .