Merge lp:~dcaro/clicompanion/fix-819038 into lp:clicompanion

[David Caro]

Fixed the bug 819038: if the command has ":" character, the command gets broken into two

Now the commands are separated with tabs.

[Duane Hinnen (duanedesign)]

Hi,
Thank you for the contribution.
I thought we had fixed this bug.
I am unable to reproduce the problem.
If you are able to reproduce this please let me know and explain the command you are using so I can test it to see the problem.
Thank you!
Duane

review: Needs Information

[Marek Bardoński (bdfhjk)]

I rejected this branch, because I working on another with full path.

This path (branch) will produce critical bug after updating from old version (it will crash trying to read old stored commands).

Unmerged revisions

=== modified file '.clicompanion'
--- .clicompanion	2010-09-20 01:15:23 +0000
+++ .clicompanion	2011-08-01 19:03:55 +0000
@@ -1,48 +1,48 @@
-dpkg -l @: package : Find version of a package
-df -h: : file system disk space usage
-free -m: : show RAM usage
-ps auxww | grep @: process : displays information about the active process
-iwconfig: : Display wireless network information
-ifconfig -a: : displays the status of the currently active interfaces
-sudo iwlist: : scan Scan Wireless networks
-sudo /etc/init.d/networking restart: : Reset the Network
-lsb_release -a: : What version of Ubuntu do I have?
-uname -a: : What kernel am I running
-sudo apt-get update && sudo apt-get upgrade: : Refresh update info and update all packages 
-sudo apt-get clean: : clear out all packages in /var/cache/apt/archives
-sudo apt-get autoclean : : clear out obsolete packages(packages with a newer release)
-apt-cache search @ :package : Find information on a package (not installed)
-sudo lshw : : List hardware 
-lspci : : list all PCI devices
-aplay -l : : List all soundcards and digital audio devices
-cat @ :path: Read File & Print to Standard Output
-ls @ :path : List Folders Contents
-ls -lSr @ :path : Show files by size, biggest last
-mv @ :path : Move (Rename) Files
-cp @ :path : Copy Files
-sudo lspci : : attached PCI devices
-chmod @ @ : permissions, file : Change access permissions, change mode
-chown @ @: owner:group, file : Change the owner and/or group of each given file
-dmesg : : Print kernel & driver messages
-history : : Command History
-locate @ : file : Find files (updatedb to update DB)
-sudo updatedb : : update the database for locate
-which @ :command : Show full path name of command
-find -maxdepth 1 -type f | xargs grep -F @ :string : Search all regular files for 'string' in this dir
-gpg -c @ :file : Encypt a file
-gpg @ :file.gpg : Decrypt a file
-tar -xjf @ :archive.tar : Extract all files from archive.tar
-tar -czf @ :Destination.tar.gz  Source : Create Destination from Source
-iostat : : cpu and I/O statistics
-netstat : : Print network connections and interface statistics
-sudo fdisk -l @ :disk : List partition tables for specified devices
-sudo ufw enable : : Enable netfilter firewall
-sudo ufw allow @ :port : Open a port in netfilter firewall
-sudo ufw deny @ :port : Close a port in netfilter firewall
-sudo ufw disable : : Disable netfilter firewall
-cat @ @ | sort | uniq > @ : file1, file2, file3 : combine, sort and remove duplicates from 2 files
-mkisofs -V LABEL -r dir | gzip > @ :isoname.iso.gz : Create cdrom image from contents of directory
-cdrecord -v dev=/dev/cdrom -audio -pad *.wav : : Make audio CD from all wavs in current dir
-dpkg-query -W -f='${Installed-Size;10}\t${Package}\n' | sort -k1,1n : : List all installed packages by size
-tail -f /var/log/messages : : Monitor messages log file
-apropos @ :command/package : search the manual page names and descriptions
+dpkg -l @	 package 	 Find version of a package
+df -h	 	 file system disk space usage
+free -m	 	 show RAM usage
+ps auxww | grep @	 process 	 displays information about the active process
+iwconfig	 	 Display wireless network information
+ifconfig -a	 	 displays the status of the currently active interfaces
+sudo iwlist	 	 scan Scan Wireless networks
+sudo /etc/init.d/networking restart	 	 Reset the Network
+lsb_release -a	 	 What version of Ubuntu do I have?
+uname -a	 	 What kernel am I running
+sudo apt-get update && sudo apt-get upgrade	 	 Refresh update info and update all packages 
+sudo apt-get clean	 	 clear out all packages in /var/cache/apt/archives
+sudo apt-get autoclean 	 	 clear out obsolete packages(packages with a newer release)
+apt-cache search @ 	package 	 Find information on a package (not installed)
+sudo lshw 	 	 List hardware 
+lspci 	 	 list all PCI devices
+aplay -l 	 	 List all soundcards and digital audio devices
+cat @ 	path	 Read File & Print to Standard Output
+ls @ 	path 	 List Folders Contents
+ls -lSr @ 	path 	 Show files by size, biggest last
+mv @ 	path 	 Move (Rename) Files
+cp @ 	path 	 Copy Files
+sudo lspci 	 	 attached PCI devices
+chmod @ @ 	 permissions, file 	 Change access permissions, change mode
+chown @ @	 owner	group, file 	 Change the owner and/or group of each given file
+dmesg 	 	 Print kernel & driver messages
+history 	 	 Command History
+locate @ 	 file 	 Find files (updatedb to update DB)
+sudo updatedb 	 	 update the database for locate
+which @ 	command 	 Show full path name of command
+find -maxdepth 1 -type f | xargs grep -F @ 	string 	 Search all regular files for 'string' in this dir
+gpg -c @ 	file 	 Encypt a file
+gpg @ 	file.gpg 	 Decrypt a file
+tar -xjf @ 	archive.tar 	 Extract all files from archive.tar
+tar -czf @ 	Destination.tar.gz  Source 	 Create Destination from Source
+iostat 	 	 cpu and I/O statistics
+netstat 	 	 Print network connections and interface statistics
+sudo fdisk -l @ 	disk 	 List partition tables for specified devices
+sudo ufw enable 	 	 Enable netfilter firewall
+sudo ufw allow @ 	port 	 Open a port in netfilter firewall
+sudo ufw deny @ 	port 	 Close a port in netfilter firewall
+sudo ufw disable 	 	 Disable netfilter firewall
+cat @ @ | sort | uniq > @ 	 file1, file2, file3 	 combine, sort and remove duplicates from 2 files
+mkisofs -V LABEL -r dir | gzip > @ 	isoname.iso.gz 	 Create cdrom image from contents of directory
+cdrecord -v dev=/dev/cdrom -audio -pad *.wav 	 	 Make audio CD from all wavs in current dir
+dpkg-query -W -f='${Installed-Size;10}\t${Package}\n' | sort -k1,1n 	 	 List all installed packages by size
+tail -f /var/log/messages 	 	 Monitor messages log file
+apropos @ 	command/package 	 search the manual page names and descriptions

=== modified file 'clicompanionlib/controller.py'
--- clicompanionlib/controller.py	2011-05-21 20:23:59 +0000
+++ clicompanionlib/controller.py	2011-08-01 19:03:55 +0000
@@ -160,12 +160,12 @@
             if text1 != "":
                 with open(CHEATSHEET, "r") as cheatfile:
                     cheatlines = cheatfile.readlines()
-                    cheatlines.append(text1+":"+text2+":"+text3+'\n')
+                    cheatlines.append(text1+"\t"+text2+"\t"+text3+'\n')
                     cheatfile.close()
                 with open(CHEATSHEET, "w") as cheatfile2:
                     cheatfile2.writelines(cheatlines)
                     cheatfile2.close()
-                    l = str(text1+":"+text2+":"+text3)
+                    l = str(text1+"\t"+text2+"\t"+text3)
                     #ls = l.split(':',2)
                     ## update view.CMNDS variable
                     filteredcommandplus = text1, text2, text3

=== modified file 'clicompanionlib/view.py'
--- clicompanionlib/view.py	2011-06-11 10:30:58 +0000
+++ clicompanionlib/view.py	2011-08-01 19:03:55 +0000
@@ -104,7 +104,7 @@
 
         ## add bug data from .clicompanion --> bugdata --> to the liststore
         for line in bugdata.splitlines():
-            l = line.split(':',2)
+            l = line.split('\t',2)
             commandplus = l[0], l[1], l[2]
             CMNDS.append(commandplus)
             self.liststore.append([l[0],l[1],l[2]])

=== modified file 'data/clicompanion2.config'
--- data/clicompanion2.config	2010-11-30 16:03:59 +0000
+++ data/clicompanion2.config	2011-08-01 19:03:55 +0000
@@ -1,48 +1,48 @@
-dpkg -l ?:package:Find version of a package
-df -h::file system disk space usage
-free -m::show RAM usage
-ps auxww | grep ?:process:displays information about the active process
-iwconfig::Display wireless network information
-ifconfig -a::displays the status of the currently active interfaces
-sudo iwlist::scan Scan Wireless networks
-sudo /etc/init.d/networking restart::Reset the Network
-lsb_release -a::What version of Ubuntu do I have?
-uname -a::What kernel am I running
-sudo apt-get update && sudo apt-get upgrade::Refresh update info and update all packages 
-sudo apt-get clean::clear out all packages in /var/cache/apt/archives
-sudo apt-get autoclean::clear out obsolete packages(packages with a newer release)
-apt-cache search ?:package:Find information on a package (not installed)
-sudo lshw::List hardware 
-lspci::list all PCI devices
-aplay -l::List all soundcards and digital audio devices
-cat ?:path:Read File & Print to Standard Output
-ls ? :path:List Folders Contents
-ls -lSr ?:path:Show files by size, biggest last
-mv ?:path:Move (Rename) Files
-cp ?:path:Copy Files
-sudo lspci::attached PCI devices
-chmod ? ?:permissions, file:Change access permissions, change mode
-chown ? ?:owner,group, file:Change the owner and/or group of each given file
-dmesg::Print kernel & driver messages
-history::Command History
-locate ?:file:Find files (updatedb to update DB)
-sudo updatedb::update the database for locate
-which ?:command:Show full path name of command
-find -maxdepth 1 -type f | xargs grep -F ?:string:Search all regular files for 'string' in this dir
-gpg -c ?:file:Encypt a file
-gpg ?:file.gpg:Decrypt a file
-tar -xjf ?:archive.tar:Extract all files from archive.tar
-tar -czf ?:Destination.tar.gz  Source:Create Destination from Source
-iostat::cpu and I/O statistics
-netstat::Print network connections and interface statistics
-sudo fdisk -l ?:disk:List partition tables for specified devices
-sudo ufw enable::Enable netfilter firewall
-sudo ufw allow ?:port:Open a port in netfilter firewall
-sudo ufw deny ?:port:Close a port in netfilter firewall
-sudo ufw disable::Disable netfilter firewall
-cat ? ? | sort | uniq > ? :file1, file2, file3:combine, sort and remove duplicates from 2 files
-mkisofs -V LABEL -r dir | gzip > ?:isoname.iso.gz:Create cdrom image(iso) from contents of directory(pwd)
-cdrecord -v dev=/dev/cdrom -audio -pad *.wav::Make audio CD from all wavs in current dir(pwd)
-dpkg-query -W -f='${Installed-Size;10}\t${Package}\n' | sort -k1,1n::List all installed packages by size
-tail -f /var/log/messages::Monitor messages log file
-apropos ?:command or package:search the manual page names and descriptions
+dpkg -l ?	package	Find version of a package
+df -h		file system disk space usage
+free -m		show RAM usage
+ps auxww | grep ?	process	displays information about the active process
+iwconfig		Display wireless network information
+ifconfig -a		displays the status of the currently active interfaces
+sudo iwlist		scan Scan Wireless networks
+sudo /etc/init.d/networking restart		Reset the Network
+lsb_release -a		What version of Ubuntu do I have?
+uname -a		What kernel am I running
+sudo apt-get update && sudo apt-get upgrade		Refresh update info and update all packages 
+sudo apt-get clean		clear out all packages in /var/cache/apt/archives
+sudo apt-get autoclean		clear out obsolete packages(packages with a newer release)
+apt-cache search ?	package	Find information on a package (not installed)
+sudo lshw		List hardware 
+lspci		list all PCI devices
+aplay -l		List all soundcards and digital audio devices
+cat ?	path	Read File & Print to Standard Output
+ls ? 	path	List Folders Contents
+ls -lSr ?	path	Show files by size, biggest last
+mv ?	path	Move (Rename) Files
+cp ?	path	Copy Files
+sudo lspci		attached PCI devices
+chmod ? ?	permissions, file	Change access permissions, change mode
+chown ? ?	owner,group, file	Change the owner and/or group of each given file
+dmesg		Print kernel & driver messages
+history		Command History
+locate ?	file	Find files (updatedb to update DB)
+sudo updatedb		update the database for locate
+which ?	command	Show full path name of command
+find -maxdepth 1 -type f | xargs grep -F ?	string	Search all regular files for 'string' in this dir
+gpg -c ?	file	Encypt a file
+gpg ?	file.gpg	Decrypt a file
+tar -xjf ?	archive.tar	Extract all files from archive.tar
+tar -czf ?	Destination.tar.gz  Source	Create Destination from Source
+iostat		cpu and I/O statistics
+netstat		Print network connections and interface statistics
+sudo fdisk -l ?	disk	List partition tables for specified devices
+sudo ufw enable		Enable netfilter firewall
+sudo ufw allow ?	port	Open a port in netfilter firewall
+sudo ufw deny ?	port	Close a port in netfilter firewall
+sudo ufw disable		Disable netfilter firewall
+cat ? ? | sort | uniq > ? 	file1, file2, file3	combine, sort and remove duplicates from 2 files
+mkisofs -V LABEL -r dir | gzip > ?	isoname.iso.gz	Create cdrom image(iso) from contents of directory(pwd)
+cdrecord -v dev=/dev/cdrom -audio -pad *.wav		Make audio CD from all wavs in current dir(pwd)
+dpkg-query -W -f='${Installed-Size;10}\t${Package}\n' | sort -k1,1n		List all installed packages by size
+tail -f /var/log/messages		Monitor messages log file
+apropos ?	command or package	search the manual page names and descriptions