Merge lp:~dbarth/webapps-demo/click-packages into lp:webapps-demo

Proposed by David Barth
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 27
Merged at revision: 26
Proposed branch: lp:~dbarth/webapps-demo/click-packages
Merge into: lp:webapps-demo
Diff against target: 364 lines (+216/-8)
20 files modified
README (+6/-0)
debian/changelog (+9/-0)
debian/control (+20/-4)
debian/postinst (+21/-0)
debian/rules (+24/-1)
debian/webapps-demo-click.install (+1/-2)
debian/webapps-demo.install (+2/-0)
webapp-amazon/manifest.json (+15/-0)
webapp-amazon/webapp-amazon.json (+7/-0)
webapp-ebay/manifest.json (+15/-0)
webapp-ebay/webapp-ebay.json (+7/-0)
webapp-facebook/manifest.json (+15/-0)
webapp-facebook/webapp-facebook.json (+7/-0)
webapp-gmail/manifest.json (+15/-0)
webapp-gmail/webapp-gmail.json (+7/-0)
webapp-twitter/manifest.json (+15/-0)
webapp-twitter/webapp-twitter.desktop (+1/-1)
webapp-twitter/webapp-twitter.json (+7/-0)
webapp-ubuntuone/manifest.json (+15/-0)
webapp-ubuntuone/webapp-ubuntuone.json (+7/-0)
To merge this branch: bzr merge lp:~dbarth/webapps-demo/click-packages
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+184639@code.launchpad.net

Commit message

Migrate webapps definitions to click packages

Description of the change

This migrates webapps definitions to click packages.

I didn't take the qmlscene.desktop for now, but it should be resolved which package should contain it moving forward.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:25
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~dbarth/webapps-demo/click-packages/+merge/184639/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/webapps-demo-ci/14/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/webapps-demo-raring-armhf-ci/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webapps-demo-raring-i386-ci/14/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webapps-demo-ci/14/rebuild

review: Needs Fixing (continuous-integration)
25. By Ugo Riboni

Remove dependency on the hud as the package will be removed. Fixes: https://bugs.launchpad.net/bugs/1221344.

Approved by Günter Schwann, PS Jenkins bot.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
26. By David Barth

re-merge click packages changes and resolve a conflict in debian/control

27. By David Barth

add click as build dependency as well

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'README'
2--- README 1970-01-01 00:00:00 +0000
3+++ README 2013-09-10 12:19:29 +0000
4@@ -0,0 +1,6 @@
5+This package provides a set of default web application versions for popular web services.
6+
7+The debian package itself serves 2 purposes:
8+- generate click packages in a clean environment, that can be integrated with the rest of our toolchain
9+- package a set of icons for the webapps, while click doesn't support icons directly (temporary)
10+
11
12=== modified file 'debian/changelog'
13--- debian/changelog 2013-07-10 21:13:25 +0000
14+++ debian/changelog 2013-09-10 12:19:29 +0000
15@@ -1,3 +1,12 @@
16+webapps-demo (0.18) saucy; urgency=low
17+
18+ * Switch to building click packages from the debian packaging shell
19+ * Migrate apps in a click package, using the new webapp containment system
20+ * Keep the icon set in the main package (temporary)
21+ * Add sub-package to pre-install click packages in the base system image
22+
23+ -- David Barth <david.barth@canonical.com> Mon, 09 Sep 2013 12:41:02 +0200
24+
25 webapps-demo (0.17) saucy; urgency=low
26
27 * Remove all qml mocks. (LP: #1198850)
28
29=== modified file 'debian/control'
30--- debian/control 2013-09-10 08:17:10 +0000
31+++ debian/control 2013-09-10 12:19:29 +0000
32@@ -3,14 +3,30 @@
33 Priority: extra
34 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
35 XSBC-Original-Maintainer: Ricardo Mendoza <ricardo.mendoza@canonical.com>
36-Build-Depends: debhelper (>= 9.0.0)
37+Build-Depends: debhelper (>= 9.0.0),
38+ click
39 Standards-Version: 3.9.3
40 Vcs-Bzr: lp:webapps-demo
41
42+Package: webapps-demo-click
43+Architecture: all
44+Depends: ${shlibs:Depends},
45+ ${misc:Depends},
46+ webapps-demo,
47+ webbrowser-app,
48+ qtdeclarative5-hud1.0,
49+ click,
50+Description: Default web applications set (as click packages)
51+ Default web applications set, to demonstrate the integration
52+ of popuplar web services on Ubuntu.
53+ This package contains click packages that will are pre-installed
54+ in the base image.
55+
56 Package: webapps-demo
57 Architecture: all
58 Depends: ${shlibs:Depends},
59 ${misc:Depends},
60- webbrowser-app,
61-Description: WebApps assets for demo
62- Facebook and Twitter assets for standalone launcher
63+Description: Icon set for the default web applications set
64+ This pacakge contains a temporary icon set for use with the default
65+ set of web applications.
66+
67
68=== added file 'debian/postinst'
69--- debian/postinst 1970-01-01 00:00:00 +0000
70+++ debian/postinst 2013-09-10 12:19:29 +0000
71@@ -0,0 +1,21 @@
72+#!/bin/sh
73+
74+set -e
75+
76+echo "Setting up click packages"
77+
78+click_db=/usr/share/click/preinstalled
79+tmpdir=/tmp/webapps-demo
80+
81+mkdir -p -m 755 "$click_db"
82+chown clickpkg:clickpkg "$click_db"
83+
84+for package in $(ls "$tmpdir")
85+do
86+ echo "Setting up $package"
87+ # WARNING: install for user phablet, as --all-users doesn't install
88+ # the aa-exec frontend to enable the containment of webapps
89+ click install --force-missing-framework --root="$click_db" \
90+ --user=phablet \
91+ "$tmpdir/$package"
92+done
93
94=== modified file 'debian/rules'
95--- debian/rules 2012-11-19 15:43:52 +0000
96+++ debian/rules 2013-09-10 12:19:29 +0000
97@@ -10,12 +10,35 @@
98 # Modified to make a template file for a multi-binary package with separated
99 # build-arch and build-indep targets by Bill Allombert 2001
100
101+include /usr/share/dpkg/default.mk
102+
103 # Uncomment this to turn on verbose mode.
104 #export DH_VERBOSE=1
105
106 # This has to be exported to make some magic below work.
107 export DH_OPTIONS
108
109-
110 %:
111 dh $@
112+
113+build_click = make -f debian/rules click APP=$(1)
114+
115+click:
116+ mkdir -p build
117+ cd build; click build ../$(APP)
118+
119+override_dh_auto_conf:
120+ rm -rf build
121+ mkdir -p build
122+
123+override_dh_auto_build:
124+ $(call build_click,webapp-twitter)
125+ $(call build_click,webapp-ebay)
126+ $(call build_click,webapp-amazon)
127+ $(call build_click,webapp-facebook)
128+ $(call build_click,webapp-ubuntuone)
129+ $(call build_click,webapp-gmail)
130+
131+override_dh_clean:
132+ rm -rf build
133+ dh_clean
134
135=== renamed file 'debian/webapps-demo.install' => 'debian/webapps-demo-click.install'
136--- debian/webapps-demo.install 2013-07-10 19:40:11 +0000
137+++ debian/webapps-demo-click.install 2013-09-10 12:19:29 +0000
138@@ -1,2 +1,1 @@
139-desktopFiles/*.desktop /usr/share/applications/
140-icons/* /usr/share/icons/hicolor/
141+build/* /tmp/webapps-demo/
142
143=== added file 'debian/webapps-demo.install'
144--- debian/webapps-demo.install 1970-01-01 00:00:00 +0000
145+++ debian/webapps-demo.install 2013-09-10 12:19:29 +0000
146@@ -0,0 +1,2 @@
147+icons/* /usr/share/icons/hicolor/
148+desktopFiles/* /usr/share/applications/
149
150=== added directory 'webapp-amazon'
151=== added file 'webapp-amazon/manifest.json'
152--- webapp-amazon/manifest.json 1970-01-01 00:00:00 +0000
153+++ webapp-amazon/manifest.json 2013-09-10 12:19:29 +0000
154@@ -0,0 +1,15 @@
155+{
156+ "description": "Amazon (webapp version)",
157+ "framework": "ubuntu-sdk-13.10",
158+ "hooks": {
159+ "webapp-amazon": {
160+ "apparmor": "webapp-amazon.json",
161+ "desktop": "webapp-amazon.desktop"
162+ }
163+ },
164+ "maintainer": "Webapps Team <webapps@lists.launchpad.net>",
165+ "name": "com.ubuntu.developer.webapps.webapp-amazon",
166+ "title": "webapp-amazon",
167+ "version": "1.0"
168+}
169+
170
171=== renamed file 'desktopFiles/amazon-webapp.desktop' => 'webapp-amazon/webapp-amazon.desktop'
172=== added file 'webapp-amazon/webapp-amazon.json'
173--- webapp-amazon/webapp-amazon.json 1970-01-01 00:00:00 +0000
174+++ webapp-amazon/webapp-amazon.json 2013-09-10 12:19:29 +0000
175@@ -0,0 +1,7 @@
176+{
177+ "template": "ubuntu-webapp-experimental",
178+ "policy_groups": [
179+ "networking"
180+ ],
181+ "policy_version": 1.0
182+}
183
184=== added directory 'webapp-ebay'
185=== added file 'webapp-ebay/manifest.json'
186--- webapp-ebay/manifest.json 1970-01-01 00:00:00 +0000
187+++ webapp-ebay/manifest.json 2013-09-10 12:19:29 +0000
188@@ -0,0 +1,15 @@
189+{
190+ "description": "eBay (webapp version)",
191+ "framework": "ubuntu-sdk-13.10",
192+ "hooks": {
193+ "webapp-ebay": {
194+ "apparmor": "webapp-ebay.json",
195+ "desktop": "webapp-ebay.desktop"
196+ }
197+ },
198+ "maintainer": "Webapps Team <webapps@lists.launchpad.net>",
199+ "name": "com.ubuntu.developer.webapps.webapp-ebay",
200+ "title": "webapp-ebay",
201+ "version": "1.0"
202+}
203+
204
205=== renamed file 'desktopFiles/ebay-webapp.desktop' => 'webapp-ebay/webapp-ebay.desktop'
206=== added file 'webapp-ebay/webapp-ebay.json'
207--- webapp-ebay/webapp-ebay.json 1970-01-01 00:00:00 +0000
208+++ webapp-ebay/webapp-ebay.json 2013-09-10 12:19:29 +0000
209@@ -0,0 +1,7 @@
210+{
211+ "template": "ubuntu-webapp-experimental",
212+ "policy_groups": [
213+ "networking"
214+ ],
215+ "policy_version": 1.0
216+}
217
218=== added directory 'webapp-facebook'
219=== added file 'webapp-facebook/manifest.json'
220--- webapp-facebook/manifest.json 1970-01-01 00:00:00 +0000
221+++ webapp-facebook/manifest.json 2013-09-10 12:19:29 +0000
222@@ -0,0 +1,15 @@
223+{
224+ "description": "Facebook (webapp version)",
225+ "framework": "ubuntu-sdk-13.10",
226+ "hooks": {
227+ "webapp-facebook": {
228+ "apparmor": "webapp-facebook.json",
229+ "desktop": "webapp-facebook.desktop"
230+ }
231+ },
232+ "maintainer": "Webapps Team <webapps@lists.launchpad.net>",
233+ "name": "com.ubuntu.developer.webapps.webapp-facebook",
234+ "title": "webapp-facebook",
235+ "version": "1.0"
236+}
237+
238
239=== renamed file 'desktopFiles/facebook-webapp.desktop' => 'webapp-facebook/webapp-facebook.desktop'
240=== added file 'webapp-facebook/webapp-facebook.json'
241--- webapp-facebook/webapp-facebook.json 1970-01-01 00:00:00 +0000
242+++ webapp-facebook/webapp-facebook.json 2013-09-10 12:19:29 +0000
243@@ -0,0 +1,7 @@
244+{
245+ "template": "ubuntu-webapp-experimental",
246+ "policy_groups": [
247+ "networking"
248+ ],
249+ "policy_version": 1.0
250+}
251
252=== added directory 'webapp-gmail'
253=== added file 'webapp-gmail/manifest.json'
254--- webapp-gmail/manifest.json 1970-01-01 00:00:00 +0000
255+++ webapp-gmail/manifest.json 2013-09-10 12:19:29 +0000
256@@ -0,0 +1,15 @@
257+{
258+ "description": "GMail (webapp version)",
259+ "framework": "ubuntu-sdk-13.10",
260+ "hooks": {
261+ "webapp-gmail": {
262+ "apparmor": "webapp-gmail.json",
263+ "desktop": "webapp-gmail.desktop"
264+ }
265+ },
266+ "maintainer": "Webapps Team <webapps@lists.launchpad.net>",
267+ "name": "com.ubuntu.developer.webapps.webapp-gmail",
268+ "title": "webapp-gmail",
269+ "version": "1.0"
270+}
271+
272
273=== renamed file 'desktopFiles/gmail-webapp.desktop' => 'webapp-gmail/webapp-gmail.desktop'
274=== added file 'webapp-gmail/webapp-gmail.json'
275--- webapp-gmail/webapp-gmail.json 1970-01-01 00:00:00 +0000
276+++ webapp-gmail/webapp-gmail.json 2013-09-10 12:19:29 +0000
277@@ -0,0 +1,7 @@
278+{
279+ "template": "ubuntu-webapp-experimental",
280+ "policy_groups": [
281+ "networking"
282+ ],
283+ "policy_version": 1.0
284+}
285
286=== added directory 'webapp-twitter'
287=== added file 'webapp-twitter/manifest.json'
288--- webapp-twitter/manifest.json 1970-01-01 00:00:00 +0000
289+++ webapp-twitter/manifest.json 2013-09-10 12:19:29 +0000
290@@ -0,0 +1,15 @@
291+{
292+ "description": "Twitter (webapp version)",
293+ "framework": "ubuntu-sdk-13.10",
294+ "hooks": {
295+ "webapp-twitter": {
296+ "apparmor": "webapp-twitter.json",
297+ "desktop": "webapp-twitter.desktop"
298+ }
299+ },
300+ "maintainer": "Webapps Team <webapps@lists.launchpad.net>",
301+ "name": "com.ubuntu.developer.webapps.webapp-twitter",
302+ "title": "webapp-twitter",
303+ "version": "1.0"
304+}
305+
306
307=== renamed file 'desktopFiles/twitter-webapp.desktop' => 'webapp-twitter/webapp-twitter.desktop'
308--- desktopFiles/twitter-webapp.desktop 2013-04-02 12:55:05 +0000
309+++ webapp-twitter/webapp-twitter.desktop 2013-09-10 12:19:29 +0000
310@@ -1,7 +1,7 @@
311 [Desktop Entry]
312 Type=Application
313 Terminal=false
314-Exec=webbrowser-app --chromeless http://mobile.twitter.com
315+Exec=webbrowser-app --chromeless --webapp http://mobile.twitter.com
316 Name=Twitter
317 Icon=twitter
318 X-Ubuntu-Touch=true
319
320=== added file 'webapp-twitter/webapp-twitter.json'
321--- webapp-twitter/webapp-twitter.json 1970-01-01 00:00:00 +0000
322+++ webapp-twitter/webapp-twitter.json 2013-09-10 12:19:29 +0000
323@@ -0,0 +1,7 @@
324+{
325+ "template": "ubuntu-webapp-experimental",
326+ "policy_groups": [
327+ "networking"
328+ ],
329+ "policy_version": 1.0
330+}
331
332=== added directory 'webapp-ubuntuone'
333=== added file 'webapp-ubuntuone/manifest.json'
334--- webapp-ubuntuone/manifest.json 1970-01-01 00:00:00 +0000
335+++ webapp-ubuntuone/manifest.json 2013-09-10 12:19:29 +0000
336@@ -0,0 +1,15 @@
337+{
338+ "description": "Ubuntu One (webapp version)",
339+ "framework": "ubuntu-sdk-13.10",
340+ "hooks": {
341+ "webapp-ubuntuone": {
342+ "apparmor": "webapp-ubuntuone.json",
343+ "desktop": "webapp-ubuntuone.desktop"
344+ }
345+ },
346+ "maintainer": "Webapps Team <webapps@lists.launchpad.net>",
347+ "name": "com.ubuntu.developer.webapps.webapp-ubuntuone",
348+ "title": "webapp-ubuntuone",
349+ "version": "1.0"
350+}
351+
352
353=== renamed file 'desktopFiles/ubuntuone-webapp.desktop' => 'webapp-ubuntuone/webapp-ubuntuone.desktop'
354=== added file 'webapp-ubuntuone/webapp-ubuntuone.json'
355--- webapp-ubuntuone/webapp-ubuntuone.json 1970-01-01 00:00:00 +0000
356+++ webapp-ubuntuone/webapp-ubuntuone.json 2013-09-10 12:19:29 +0000
357@@ -0,0 +1,7 @@
358+{
359+ "template": "ubuntu-webapp-experimental",
360+ "policy_groups": [
361+ "networking"
362+ ],
363+ "policy_version": 1.0
364+}

Subscribers

People subscribed via source and target branches