Merge lp:~dbarth/webapps-demo/click-packages-take-three into lp:webapps-demo

Proposed by David Barth
Status: Merged
Merged at revision: 27
Proposed branch: lp:~dbarth/webapps-demo/click-packages-take-three
Merge into: lp:webapps-demo
Diff against target: 198 lines (+31/-26)
15 files modified
README (+3/-0)
build.sh (+10/-0)
desktopFiles/qmlscene.desktop (+0/-8)
webapp-amazon/webapp-amazon.desktop (+2/-2)
webapp-amazon/webapp-amazon.json (+1/-1)
webapp-ebay/webapp-ebay.desktop (+2/-2)
webapp-ebay/webapp-ebay.json (+1/-1)
webapp-facebook/webapp-facebook.desktop (+2/-2)
webapp-facebook/webapp-facebook.json (+1/-1)
webapp-gmail/webapp-gmail.desktop (+2/-2)
webapp-gmail/webapp-gmail.json (+1/-1)
webapp-twitter/webapp-twitter.desktop (+2/-2)
webapp-twitter/webapp-twitter.json (+1/-1)
webapp-ubuntuone/webapp-ubuntuone.desktop (+2/-2)
webapp-ubuntuone/webapp-ubuntuone.json (+1/-1)
To merge this branch: bzr merge lp:~dbarth/webapps-demo/click-packages-take-three
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+185460@code.launchpad.net

Description of the change

click packages built without deb
icon local to the package

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:31
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~dbarth/webapps-demo/click-packages-take-three/+merge/185460/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/webapps-demo-ci/20/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-armhf-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-i386-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webapps-demo-ci/20/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2013-09-09 17:48:39 +0000
3+++ README 2013-09-13 10:36:46 +0000
4@@ -4,3 +4,6 @@
5 - generate click packages in a clean environment, that can be integrated with the rest of our toolchain
6 - package a set of icons for the webapps, while click doesn't support icons directly (temporary)
7
8+To generate the click packages directly, ie without the debian package:
9+
10+./build.sh
11
12=== added file 'build.sh'
13--- build.sh 1970-01-01 00:00:00 +0000
14+++ build.sh 2013-09-13 10:36:46 +0000
15@@ -0,0 +1,10 @@
16+#!/bin/sh
17+#
18+
19+rm -rf build
20+mkdir -p build
21+cd build
22+
23+for i in `ls -d ../webapp-*`; do
24+ click build $i
25+done
26
27=== removed directory 'desktopFiles'
28=== removed file 'desktopFiles/qmlscene.desktop'
29--- desktopFiles/qmlscene.desktop 2013-04-02 13:09:42 +0000
30+++ desktopFiles/qmlscene.desktop 1970-01-01 00:00:00 +0000
31@@ -1,8 +0,0 @@
32-[Desktop Entry]
33-Encoding=UTF-8
34-Type=Application
35-Exec=/usr/bin/qmlscene
36-Name=QML runner
37-GenericName=QML runner
38-Icon=ubuntu-qmlrunner
39-NoDisplay=true
40
41=== renamed file 'icons/128/amazon.png' => 'webapp-amazon/amazon.png'
42=== modified file 'webapp-amazon/webapp-amazon.desktop'
43--- webapp-amazon/webapp-amazon.desktop 2013-09-09 17:48:39 +0000
44+++ webapp-amazon/webapp-amazon.desktop 2013-09-13 10:36:46 +0000
45@@ -1,7 +1,7 @@
46 [Desktop Entry]
47 Type=Application
48 Terminal=false
49-Exec=webbrowser-app --chromeless http://m.amazon.com
50+Exec=webbrowser-app --chromeless --enable-back-forward --webapp --webappUrlPatterns=http://m.amazon.com* http://m.amazon.com
51 Name=Amazon
52-Icon=amazon
53+Icon=./amazon.png
54 X-Ubuntu-Touch=true
55
56=== modified file 'webapp-amazon/webapp-amazon.json'
57--- webapp-amazon/webapp-amazon.json 2013-09-09 17:48:39 +0000
58+++ webapp-amazon/webapp-amazon.json 2013-09-13 10:36:46 +0000
59@@ -1,5 +1,5 @@
60 {
61- "template": "ubuntu-webapp-experimental",
62+ "template": "ubuntu-webapp",
63 "policy_groups": [
64 "networking"
65 ],
66
67=== renamed file 'icons/128/ebay.png' => 'webapp-ebay/ebay.png'
68=== modified file 'webapp-ebay/webapp-ebay.desktop'
69--- webapp-ebay/webapp-ebay.desktop 2013-09-09 17:48:39 +0000
70+++ webapp-ebay/webapp-ebay.desktop 2013-09-13 10:36:46 +0000
71@@ -1,7 +1,7 @@
72 [Desktop Entry]
73 Type=Application
74 Terminal=false
75-Exec=webbrowser-app --chromeless http://ebay.com
76+Exec=webbrowser-app --chromeless --enable-back-forward --webapp --webappUrlPatterns=http://ebay.com* http://ebay.com
77 Name=eBay
78-Icon=ebay
79+Icon=./ebay.png
80 X-Ubuntu-Touch=true
81
82=== modified file 'webapp-ebay/webapp-ebay.json'
83--- webapp-ebay/webapp-ebay.json 2013-09-09 17:48:39 +0000
84+++ webapp-ebay/webapp-ebay.json 2013-09-13 10:36:46 +0000
85@@ -1,5 +1,5 @@
86 {
87- "template": "ubuntu-webapp-experimental",
88+ "template": "ubuntu-webapp",
89 "policy_groups": [
90 "networking"
91 ],
92
93=== renamed file 'icons/128/facebook.png' => 'webapp-facebook/facebook.png'
94=== modified file 'webapp-facebook/webapp-facebook.desktop'
95--- webapp-facebook/webapp-facebook.desktop 2013-09-09 17:48:39 +0000
96+++ webapp-facebook/webapp-facebook.desktop 2013-09-13 10:36:46 +0000
97@@ -1,8 +1,8 @@
98 [Desktop Entry]
99 Type=Application
100 Terminal=false
101-Exec=webbrowser-app --chromeless http://m.facebook.com
102+Exec=webbrowser-app --chromeless --enable-back-forward --webapp --webappUrlPatterns=http://m.facebook.com* http://m.facebook.com
103 Name=Facebook
104-Icon=facebook
105+Icon=./facebook.png
106 X-Ubuntu-Touch=true
107 X-Ubuntu-StageHint=SideStage
108
109=== modified file 'webapp-facebook/webapp-facebook.json'
110--- webapp-facebook/webapp-facebook.json 2013-09-09 17:48:39 +0000
111+++ webapp-facebook/webapp-facebook.json 2013-09-13 10:36:46 +0000
112@@ -1,5 +1,5 @@
113 {
114- "template": "ubuntu-webapp-experimental",
115+ "template": "ubuntu-webapp",
116 "policy_groups": [
117 "networking"
118 ],
119
120=== renamed file 'icons/128/gmail.png' => 'webapp-gmail/gmail.png'
121=== modified file 'webapp-gmail/webapp-gmail.desktop'
122--- webapp-gmail/webapp-gmail.desktop 2013-09-09 17:48:39 +0000
123+++ webapp-gmail/webapp-gmail.desktop 2013-09-13 10:36:46 +0000
124@@ -1,7 +1,7 @@
125 [Desktop Entry]
126 Type=Application
127 Terminal=false
128-Exec=webbrowser-app --chromeless https://gmail.com
129+Exec=webbrowser-app --chromeless --enable-back-forward --webapp --webappUrlPatterns=https://gmail.com* https://gmail.com
130 Name=Gmail
131-Icon=gmail
132+Icon=./gmail.png
133 X-Ubuntu-Touch=true
134
135=== modified file 'webapp-gmail/webapp-gmail.json'
136--- webapp-gmail/webapp-gmail.json 2013-09-09 17:48:39 +0000
137+++ webapp-gmail/webapp-gmail.json 2013-09-13 10:36:46 +0000
138@@ -1,5 +1,5 @@
139 {
140- "template": "ubuntu-webapp-experimental",
141+ "template": "ubuntu-webapp",
142 "policy_groups": [
143 "networking"
144 ],
145
146=== renamed file 'icons/128/twitter.png' => 'webapp-twitter/twitter.png'
147Binary files icons/128/twitter.png 2012-11-19 15:43:52 +0000 and webapp-twitter/twitter.png 2013-09-13 10:36:46 +0000 differ
148=== modified file 'webapp-twitter/webapp-twitter.desktop'
149--- webapp-twitter/webapp-twitter.desktop 2013-09-09 17:48:39 +0000
150+++ webapp-twitter/webapp-twitter.desktop 2013-09-13 10:36:46 +0000
151@@ -1,8 +1,8 @@
152 [Desktop Entry]
153 Type=Application
154 Terminal=false
155-Exec=webbrowser-app --chromeless --webapp http://mobile.twitter.com
156+Exec=webbrowser-app --chromeless --enable-back-forward --webapp --webappUrlPatterns=http://mobile.twitter.com* http://mobile.twitter.com
157 Name=Twitter
158-Icon=twitter
159+Icon=./twitter.png
160 X-Ubuntu-Touch=true
161 X-Ubuntu-StageHint=SideStage
162
163=== modified file 'webapp-twitter/webapp-twitter.json'
164--- webapp-twitter/webapp-twitter.json 2013-09-09 17:48:39 +0000
165+++ webapp-twitter/webapp-twitter.json 2013-09-13 10:36:46 +0000
166@@ -1,5 +1,5 @@
167 {
168- "template": "ubuntu-webapp-experimental",
169+ "template": "ubuntu-webapp",
170 "policy_groups": [
171 "networking"
172 ],
173
174=== renamed file 'icons/128/ubuntuone.png' => 'webapp-ubuntuone/ubuntuone.png'
175=== modified file 'webapp-ubuntuone/webapp-ubuntuone.desktop'
176--- webapp-ubuntuone/webapp-ubuntuone.desktop 2013-09-09 17:48:39 +0000
177+++ webapp-ubuntuone/webapp-ubuntuone.desktop 2013-09-13 10:36:46 +0000
178@@ -1,7 +1,7 @@
179 [Desktop Entry]
180 Type=Application
181 Terminal=false
182-Exec=webbrowser-app --chromeless http://one.ubuntu.com
183+Exec=webbrowser-app --chromeless --enable-back-forward --webapp --webappUrlPatterns=http://one.ubuntu.com* http://one.ubuntu.com
184 Name=Ubuntu One
185-Icon=ubuntuone
186+Icon=./ubuntuone.png
187 X-Ubuntu-Touch=true
188
189=== modified file 'webapp-ubuntuone/webapp-ubuntuone.json'
190--- webapp-ubuntuone/webapp-ubuntuone.json 2013-09-09 17:48:39 +0000
191+++ webapp-ubuntuone/webapp-ubuntuone.json 2013-09-13 10:36:46 +0000
192@@ -1,5 +1,5 @@
193 {
194- "template": "ubuntu-webapp-experimental",
195+ "template": "ubuntu-webapp",
196 "policy_groups": [
197 "networking"
198 ],

Subscribers

People subscribed via source and target branches