Merge lp:~dbarth/indicator-me/entry-hint into lp:indicator-me
Proposed by
David Barth
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 104 | ||||
Proposed branch: | lp:~dbarth/indicator-me/entry-hint | ||||
Merge into: | lp:indicator-me | ||||
Diff against target: |
368 lines (+189/-27) 5 files modified
src/dbus-shared-names.h (+1/-0) src/indicator-me.c (+122/-25) src/me-service-gwibber.c (+62/-2) src/me-service-gwibber.h (+1/-0) src/me-service.c (+3/-0) |
||||
To merge this branch: | bzr merge lp:~dbarth/indicator-me/entry-hint | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Needs Information | ||
Cody Russell (community) | Approve | ||
Review via email: mp+35595@code.launchpad.net |
Description of the change
Add a hint field to the broadcast field. The hint is computed from the list of protocols associated with accounts configured for broadcasting.
To post a comment you must log in.
A few concerns.
* This patch adds several translatable strings. So I don't think it can land for Maverick.
* And this comment:
179 + /* this is dangerous: it leaves the signal connected even if the dbusmenu
180 + object is disposed, for example if the service quits
181 + */
We should just remove the signal handler on distruction instead of not having it, or delete the code entirely if it's not needed.
*