Merge lp:~dbarth/compiz-core/mumble-fix into lp:compiz-core/oneiric

Proposed by David Barth
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 2802
Merged at revision: 2802
Proposed branch: lp:~dbarth/compiz-core/mumble-fix
Merge into: lp:compiz-core/oneiric
Diff against target: 23 lines (+5/-1)
1 file modified
src/window.cpp (+5/-1)
To merge this branch: bzr merge lp:~dbarth/compiz-core/mumble-fix
Reviewer Review Type Date Requested Status
Compiz Maintainers Pending
Review via email: mp+73857@code.launchpad.net

Description of the change

I have tested that fix backported from the dev. trunk and confirmed it to fix the issue with mumble.

Test case:
- start mumble
- open the dash at the same time

Issue: the dash appears under other windows; the alt-tab switcher too

With the patch applied, the dash correctly appears on top of the mumble window; that alt-tab switcher as well

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/window.cpp'
2--- src/window.cpp 2011-08-23 13:28:57 +0000
3+++ src/window.cpp 2011-09-02 17:04:23 +0000
4@@ -2182,6 +2182,9 @@
5 if (w->overrideRedirect ())
6 return true;
7
8+ if (w->destroyed ())
9+ return true;
10+
11 if (!w->priv->shaded && !w->priv->pendingMaps)
12 {
13 if (!w->isViewable () || !w->isMapped ())
14@@ -3470,7 +3473,8 @@
15 }
16 }
17
18- mask |= priv->addWindowStackChanges (&xwc, sibling);
19+ if (sibling)
20+ mask |= priv->addWindowStackChanges (&xwc, sibling);
21 }
22
23 mask |= priv->addWindowSizeChanges (&xwc, priv->serverGeometry);

Subscribers

People subscribed via source and target branches