Phablet Tools

Merge lp:~davmor2/phablet-tools/add-autoremove into lp:phablet-tools

  1. add-autoremove
  2. Merge into trunk
Proposed by Dave Morley on 2015-09-18
Status: Merged
Merged at revision: 342
Proposed branch: lp:~davmor2/phablet-tools/add-autoremove
Merge into: lp:phablet-tools
Diff against target: 12 lines (+2/-0)
1 file modified
citrain (+2/-0)
To merge this branch: bzr merge lp:~davmor2/phablet-tools/add-autoremove
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-09-18
Brendan Donegan (community) Needs Information on 2015-09-18
Ubuntu Phablet Team 2015-09-18 Pending
Review via email: mp+271631@code.launchpad.net

Commit Message

Added apt-get autoremove to dispose of any broken dependencies before rebooting. This catches incorrectly dropped dependencies when testing a silo.

Description of the Change

Added apt-get autoremove to dispose of any broken dependencies before rebooting.

To post a comment you must log in.
Brendan Donegan (brendan-donegan) wrote :

To be safe it might be necessary to do a vanilla apt-get update (without any options) prior to the autoremove as otherwise apt won't see the whole archive, just what's in the ppa. Really we need a way to properly test this too using a silo that is deliberately broken in this way.

review: Needs Information
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:342
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~davmor2/phablet-tools/add-autoremove/+merge/271631/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/447/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-armhf-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-i386-ci/24

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/447/rebuild

review: Needs Fixing (continuous-integration)
lp:~davmor2/phablet-tools/add-autoremove updated on 2015-09-18
343. By Dave Morley on 2015-09-18

Autoremove needs and apt-get update before it finds anything to remove, simply added that line before it.

Dave Morley (davmor2) wrote :

Confirmed Apt-get update was needed before the autoremove added the line to the merge.

Dave Morley (davmor2) wrote :

Meh forgot to remove my temporary change to allow multiple silos.

lp:~davmor2/phablet-tools/add-autoremove updated on 2015-09-18
344. By Dave Morley on 2015-09-18

removed my temporary multiple silos fix as that is waiting a merge from morphis already.

PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'citrain'
2--- citrain 2015-05-07 15:24:45 +0000
3+++ citrain 2015-09-18 12:13:34 +0000
4@@ -98,6 +98,8 @@
5 adb shell "echo -e 'Package: *\nPin: release o=LP-PPA-ci-train-ppa-service-$SILO\nPin-Priority: 1100' | SUDO_ASKPASS=/tmp/askpass.sh sudo -A tee /etc/apt/preferences.d/silo.pref"
6 adb shell SUDO_ASKPASS=/tmp/askpass.sh sudo -A apt-get -o Dir::Etc::SourceList=/dev/null update
7 adb shell SUDO_ASKPASS=/tmp/askpass.sh sudo -A apt-get dist-upgrade --yes
8+ adb shell SUDO_ASKPASS=/tmp/askpass.sh sudo -A apt-get update
9+ adb shell SUDO_ASKPASS=/tmp/askpass.sh sudo -A apt-get autoremove --yes
10 adb shell rm -f /tmp/askpass.sh
11 adb reboot
12 ;;

Subscribers

People subscribed via source and target branches