~davigar15/interface-prometheus:bug/ingressaddr-not-set

Branch merges

Propose for merging

Merged into interface-prometheus:master at revision 224869ce1071a9b9f85ff12967ff672a44a0a8ab

Stuart Bishop (community): Approve on 2019-10-17

Prometheus Charmers: Pending requested 2019-10-17

Canonical IS Reviewers: Pending requested 2019-10-17

Diff: 44 lines (+7/-5)

2 files modified

provides.py (+4/-2)
requires.py (+3/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

9bb2e95... by David on 2019-10-17

Add optional hostname parameter.

60f4a93... by David on 2019-10-16

Check targets instead of the port

0c3b871... by Cory Johns on 2019-09-17

Fix TypeError when hostname not on relation

Passing `unit` to `ingress_address` causes an exception to be raised:
`TypeError: expected str, bytes or os.PathLike object, not RelatedUnit`

This also switches from decorated handlers to `manage_flags` to avoid
race conditions.

Reviewed-on: https://code.launchpad.net/~johnsca/interface-prometheus/+git/interface-prometheus/+merge/372290
Reviewed-by: Kevin W Monroe <email address hidden>
Reviewed-by: Stuart Bishop <email address hidden>

db4555d... by Cory Johns on 2019-09-04

Fix TypeError when hostname not on relation

Passing `unit` to `ingress_address` causes an exception to be raised:
`TypeError: expected str, bytes or os.PathLike object, not RelatedUnit`

This also switches from decorated handlers to `manage_flags` to avoid
race conditions.

defa8b8... by Tilman Baumann on 2019-05-23

Switch from RelationBase class to Endpoint

Reviewed-on: https://code.launchpad.net/~tilmanbaumann/interface-prometheus/+git/interface-prometheus/+merge/367744
Reviewed-by: Stuart Bishop <email address hidden>

45a4be2... by Tilman Baumann on 2019-05-22

Implemented review suggestions

Better comments
Use ingress_address
Set compat flags

4c047e5... by Tilman Baumann on 2019-05-22

Switch from RelationBase class to Endpoint

This fixes several fundamental issues with 'old' reactive charms.
This implementation is intended to be compatible with existing charms.

c51e3b6... by Domas Monkus on 2017-10-05

Merge pull request #2 from tasdomas/d01-allow-specifying-labels

Pep8 fix and allow setting relation labels.

cfd8ca4... by Domas Monkus on 2017-09-22

Pep8 fix and allow setting relation labels.

6a02198... by Domas Monkus on 2016-05-13

Fix relation.