Merge lp:~davidmhewitt/slingshot/fix-1665931 into lp:~elementary-pantheon/slingshot/trunk

Proposed by David Hewitt on 2017-02-19
Status: Merged
Approved by: Daniel Fore on 2017-02-19
Approved revision: 744
Merged at revision: 744
Proposed branch: lp:~davidmhewitt/slingshot/fix-1665931
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
src/Widgets/SearchView.vala (+1/-1)
To merge this branch: bzr merge lp:~davidmhewitt/slingshot/fix-1665931
Reviewer Review Type Date Requested Status
Daniel Fore 2017-02-19 Approve on 2017-02-19
Review via email:

Commit message

Move link search results into the internet category.

Description of the change

Two separate headings for links and other actions were previously created because a label is created for each result type, actions are considered one type and links another. Both were set to have the label "Actions". This branch sorts links under an "Internet" heading.

It becomes very difficult to group links in with the actions without changing their priority and bringing them much further up the search results. Proposing this as a temporary fix until the code can be re-written to enable better groupings and sorting based upon search relevance as well as group priority.

To post a comment you must log in.
Daniel Fore (danrabbit) wrote :

Works for me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/SearchView.vala'
2--- src/Widgets/SearchView.vala 2017-02-18 21:09:29 +0000
3+++ src/Widgets/SearchView.vala 2017-02-19 00:43:31 +0000
4@@ -133,7 +133,7 @@
5 result_type = SearchItem.ResultType.INTERNET;
6 }
7 } else if (match is Synapse.LinkPlugin.Result) {
8- result_type = SearchItem.ResultType.LINK;
9+ result_type = SearchItem.ResultType.INTERNET;
10 }
12 if (result_type == SearchItem.ResultType.UNKNOWN) {


People subscribed via source and target branches