Merge lp:~davidgomes/granite/fix-fedora-build into lp:~elementary-pantheon/granite/granite

Proposed by David Gomes
Status: Rejected
Rejected by: David Gomes
Proposed branch: lp:~davidgomes/granite/fix-fedora-build
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 33 lines (+3/-3)
2 files modified
lib/CMakeLists.txt (+2/-2)
lib/granite.pc.cmake (+1/-1)
To merge this branch: bzr merge lp:~davidgomes/granite/fix-fedora-build
Reviewer Review Type Date Requested Status
Rico Tzschichholz Needs Information
Review via email: mp+200143@code.launchpad.net

Description of the change

Fixes building on Fedora.

To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Better look into using "CMAKE_INSTALL_FULL_LIBDIR"

review: Needs Information
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Or just "CMAKE_INSTALL_LIBDIR"

To pass a properly suffixed libdir and maybe require a recent cmake which includes "GNUInstallDirs" is the responsibility of the fedora packaging.

Unmerged revisions

671. By Michel Lind

Fixed compilation on Fedora.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/CMakeLists.txt'
2--- lib/CMakeLists.txt 2013-12-23 20:13:56 +0000
3+++ lib/CMakeLists.txt 2013-12-29 13:59:02 +0000
4@@ -64,7 +64,7 @@
5 if(NOT DEFINED LIB_INSTALL_DIR)
6 set(LIB_INSTALL_DIR "${CMAKE_INSTALL_PREFIX}/lib")
7 endif()
8-install (FILES ${CMAKE_CURRENT_BINARY_DIR}/${PKG_NAME}.pc DESTINATION ${LIB_INSTALL_DIR}/pkgconfig)
9+install (FILES ${CMAKE_CURRENT_BINARY_DIR}/${PKG_NAME}.pc DESTINATION ${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX}/pkgconfig)
10
11 # Link all
12 set (CFLAGS ${DEPS_CFLAGS} ${DEPS_CFLAGS_OTHER})
13@@ -105,7 +105,7 @@
14 VERSION ${PKG_SOVERSION}.${PKG_SOMINOR}
15 SOVERSION ${PKG_SOVERSION})
16
17-install (TARGETS ${PKG_NAME} DESTINATION ${LIB_INSTALL_DIR})
18+install (TARGETS ${PKG_NAME} DESTINATION ${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX})
19
20 ###########################
21 # GObject Introspection
22
23=== modified file 'lib/granite.pc.cmake'
24--- lib/granite.pc.cmake 2012-11-23 20:58:45 +0000
25+++ lib/granite.pc.cmake 2013-12-29 13:59:02 +0000
26@@ -1,6 +1,6 @@
27 prefix=@PREFIX@
28 exec_prefix=@DOLLAR@{prefix}
29-libdir=@DOLLAR@{prefix}/lib
30+libdir=@DOLLAR@{prefix}/lib@LIB_SUFFIX@
31 includedir=@DOLLAR@{prefix}/include
32
33 Name: granite

Subscribers

People subscribed via source and target branches