Merge lp:~davidgomes/appcenter/fix-window-title into lp:~elementary-apps/appcenter/appcenter-old

Proposed by David Gomes
Status: Rejected
Rejected by: David Gomes
Proposed branch: lp:~davidgomes/appcenter/fix-window-title
Merge into: lp:~elementary-apps/appcenter/appcenter-old
Diff against target: 38 lines (+3/-3)
3 files modified
data/appcenter.desktop (+1/-1)
src/AppCenter.vala (+1/-1)
src/MainWindow.vala (+1/-1)
To merge this branch: bzr merge lp:~davidgomes/appcenter/fix-window-title
Reviewer Review Type Date Requested Status
Mario Guerriero (community) Disapprove
Cassidy James Blaede Pending
Danielle Foré Pending
Review via email: mp+152584@code.launchpad.net

Description of the change

Changed the window title from 'AppCenter' to 'App Center'.

To post a comment you must log in.
161. By David Gomes

Changed title on .desktop too.

162. By David Gomes

Changed title of actuall app too.

Revision history for this message
David Gomes (davidgomes) wrote :

Adding Daniel as a reviewer too because this might need some design input.

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

The branch is ok for me. Waiting for a design approval.

review: Approve
Revision history for this message
Danielle Foré (danrabbit) wrote :

My original naming intentions were for it to be one word. But I'm not opposed to changing it if that is what you guys want to do :)

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

But if we replace "AppCenter" with "App Center" we should change also deb package and schema name and I would not like to do that. I am opposed to that, especially with having an app-center package and an app-center executable.

review: Disapprove
Revision history for this message
David Gomes (davidgomes) wrote :

Alright, then it's a no.

Unmerged revisions

162. By David Gomes

Changed title of actuall app too.

161. By David Gomes

Changed title on .desktop too.

160. By David Gomes

Changed window title to 'App Center'.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/appcenter.desktop'
2--- data/appcenter.desktop 2012-12-18 21:57:26 +0000
3+++ data/appcenter.desktop 2013-03-10 12:04:21 +0000
4@@ -1,7 +1,7 @@
5 [Desktop Entry]
6 Type=Application
7 Version=0.1
8-Name=AppCenter
9+Name=App Center
10 Comment=Find and install apps
11 GenericName=application download center
12 Exec=appcenter
13
14=== modified file 'src/AppCenter.vala'
15--- src/AppCenter.vala 2013-02-14 16:01:56 +0000
16+++ src/AppCenter.vala 2013-03-10 12:04:21 +0000
17@@ -111,7 +111,7 @@
18
19 public static int main (string[] args) {
20
21- app_cmd_name = "AppCenter";
22+ app_cmd_name = "App Center";
23
24 // Context options
25 var context = new OptionContext ("File");
26
27=== modified file 'src/MainWindow.vala'
28--- src/MainWindow.vala 2013-03-02 16:18:24 +0000
29+++ src/MainWindow.vala 2013-03-10 12:04:21 +0000
30@@ -96,7 +96,7 @@
31 apps_manager.build_database ();
32
33 window_position = WindowPosition.CENTER;
34- title = "AppCenter";
35+ title = "App Center";
36 icon_name = "system-software-installer";
37 set_default_size(640, 400);
38 has_resize_grip = true;

Subscribers

People subscribed via source and target branches