Merge lp:~davidc3/unity-scope-gallica/books-master into lp:unity-scope-gallica

Proposed by David Callé
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 26
Merged at revision: 25
Proposed branch: lp:~davidc3/unity-scope-gallica/books-master
Merge into: lp:unity-scope-gallica
Diff against target: 78 lines (+10/-11)
5 files modified
data/gallica.scope.in (+3/-3)
data/unity-scope-gallica.service (+1/-1)
setup.cfg (+1/-1)
setup.py (+0/-1)
src/unity_gallica_daemon.py (+5/-5)
To merge this branch: bzr merge lp:~davidc3/unity-scope-gallica/books-master
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+160770@code.launchpad.net

Commit message

Move to Books master and don't install __init__.py

Description of the change

Move to Books master and don't install __init__.py

To post a comment you must log in.
26. By David Callé

Complete master transition

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Works fine. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/gallica.scope.in'
2--- data/gallica.scope.in 2013-03-15 17:28:50 +0000
3+++ data/gallica.scope.in 2013-04-24 22:18:26 +0000
4@@ -1,13 +1,13 @@
5 [Scope]
6-DBusName=com.canonical.Unity.Scope.Reference.Gallica
7-DBusPath=/com/canonical/unity/scope/reference/gallica
8+DBusName=com.canonical.Unity.Scope.Books.Gallica
9+DBusPath=/com/canonical/unity/scope/books/gallica
10 Icon=
11 _Keywords=gallica;book;library;books;art;history;bnf;
12 RequiredMetadata=
13 OptionalMetadata=
14 Loader=/usr/share/unity-scopes/gallica/unity_gallica_daemon.py
15 RemoteContent=true
16-Type=reference
17+Type=books
18 _Name=Gallica
19 _Description=Find Art and Historical documents
20 _SearchHint=Search Gallica
21
22=== modified file 'data/unity-scope-gallica.service'
23--- data/unity-scope-gallica.service 2013-03-14 12:28:06 +0000
24+++ data/unity-scope-gallica.service 2013-04-24 22:18:26 +0000
25@@ -1,3 +1,3 @@
26 [D-BUS Service]
27-Name=com.canonical.Unity.Scope.Reference.Gallica
28+Name=com.canonical.Unity.Scope.Books.Gallica
29 Exec=/usr/bin/python3 /usr/share/unity-scopes/scope-runner-dbus.py /usr/share/unity-scopes/gallica/unity_gallica_daemon.py
30
31=== modified file 'setup.cfg'
32--- setup.cfg 2013-03-13 19:41:46 +0000
33+++ setup.cfg 2013-04-24 22:18:26 +0000
34@@ -3,4 +3,4 @@
35
36 [build_i18n]
37 domain=unity-scope-gallica
38-desktop_files=[('share/unity/scopes/reference', ('data/gallica.scope.in',))]
39+desktop_files=[('share/unity/scopes/books', ('data/gallica.scope.in',))]
40
41=== modified file 'setup.py'
42--- setup.py 2013-03-20 20:24:11 +0000
43+++ setup.py 2013-04-24 22:18:26 +0000
44@@ -12,6 +12,5 @@
45 data_files=[
46 ('share/dbus-1/services', ['data/unity-scope-gallica.service']),
47 ('share/unity-scopes/gallica', ['src/unity_gallica_daemon.py']),
48- ('share/unity-scopes/gallica', ['src/__init__.py']),
49 ], cmdclass={'build': build_extra.build_extra,
50 'build_i18n': build_i18n.build_i18n,})
51
52=== modified file 'src/unity_gallica_daemon.py'
53--- src/unity_gallica_daemon.py 2013-03-22 10:42:04 +0000
54+++ src/unity_gallica_daemon.py 2013-04-24 22:18:26 +0000
55@@ -27,8 +27,8 @@
56 gettext.textdomain(APP_NAME)
57 _ = gettext.gettext
58
59-GROUP_NAME = 'com.canonical.Unity.Scope.Reference.Gallica'
60-UNIQUE_PATH = '/com/canonical/unity/scope/reference/gallica'
61+GROUP_NAME = 'com.canonical.Unity.Scope.Books.Gallica'
62+UNIQUE_PATH = '/com/canonical/unity/scope/books/gallica'
63 SEARCH_URI = 'http://gallica.bnf.fr/'
64 SEARCH_HINT = _('Search Gallica')
65 NO_RESULTS_HINT = _('Sorry, there are no Gallica results that match your search.')
66@@ -39,9 +39,9 @@
67 DEFAULT_RESULT_MIMETYPE = 'text/html'
68 DEFAULT_RESULT_TYPE = Unity.ResultType.DEFAULT
69
70-c1 = {'id' :'sources',
71- 'name' :_('Art and historical documents'),
72- 'icon' :SVG_DIR + 'group-reference.svg',
73+c1 = {'id' :'top',
74+ 'name' :_('Books and historical documents'),
75+ 'icon' :SVG_DIR + 'group-books.svg',
76 'renderer':Unity.CategoryRenderer.VERTICAL_TILE}
77 CATEGORIES = [c1]
78 FILTERS = []

Subscribers

People subscribed via source and target branches

to all changes: