Merge lp:~davidc3/unity-lens-video/improve-locate into lp:unity-lens-video

Proposed by David Callé on 2012-10-16
Status: Merged
Approved by: Michal Hruby on 2012-10-16
Approved revision: 100
Merged at revision: 99
Proposed branch: lp:~davidc3/unity-lens-video/improve-locate
Merge into: lp:unity-lens-video
Diff against target: 31 lines (+15/-1)
2 files modified
src/unity-lens-video (+1/-1)
tests/manual/local-video-search.txt (+14/-0)
To merge this branch: bzr merge lp:~davidc3/unity-lens-video/improve-locate
Reviewer Review Type Date Requested Status
Michal Hruby (community) 2012-10-16 Approve on 2012-10-16
Review via email: mp+129848@code.launchpad.net

Commit Message

Replace spaces in search string by * to improve locate search.

Description of the Change

Replace spaces in search string by * to improve locate search.

To post a comment you must log in.
100. By David Callé on 2012-10-16

Add manual test for local video search

Michal Hruby (mhr3) wrote :

Great! +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/unity-lens-video'
2--- src/unity-lens-video 2012-10-10 09:37:00 +0000
3+++ src/unity-lens-video 2012-10-16 10:59:22 +0000
4@@ -257,7 +257,7 @@
5 results = GLib.spawn_sync(None,
6 ['/usr/bin/locate',
7 '-id', CACHE+'/'+DB,
8- FOLDER+'*'+search+'*' ],
9+ FOLDER+'*'+search.replace (" ","*")+'*' ],
10 None, 0, None, None)
11 except GLib.GError:
12 results = None
13
14=== added file 'tests/manual/local-video-search.txt'
15--- tests/manual/local-video-search.txt 1970-01-01 00:00:00 +0000
16+++ tests/manual/local-video-search.txt 2012-10-16 10:59:22 +0000
17@@ -0,0 +1,14 @@
18+Search a local video file
19+---------------------------
20+Test that local video files in the ~/Videos folder are easily found
21+
22+Setup:
23+Have some video files available in ~/Videos folder.
24+
25+Actions:
26+1. Open the Dash and switch to the video lens.
27+2. Make sure some video files from ~/Videos folder are displayed.
28+3. Search for multiple consecutive substrings of a video file name.
29+
30+Expected Result:
31+Results matching the search should be displayed. For example, searching for "ubuntu 1" should returns "ubuntu_video1.avi".

Subscribers

People subscribed via source and target branches