Code review comment for lp:~davidc3/resource-centre/jp-exclude-from-rss

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

The blog loads the data via the built-in WordPress Rest API. The content is not loaded from the RSS although I guess it should be hidden from that too for people using the RSS.

I have applied your branch (and updated the tag id) to [our testing enviroment](http://insights.canonicalwebteam.com).

I created an article with the tag `lang:jp`.

This article is still [visible in the API](http://insights.canonicalwebteam.com/wp-json/wp/v2/posts?per_page=3&page=1&_embed=True).

A similar approach may be to add a condition to [blog.ubuntu.com code base](https://github.com/canonical-websites/blog.ubuntu.com/). Keeping all the logic in one place, [example PR](https://github.com/canonical-websites/blog.ubuntu.com/pull/392)

With that this branch is good.

review: Approve

« Back to merge proposal