Merge lp:~davidc3/developer-ubuntu-com/translations-dashboard-1528618 into lp:developer-ubuntu-com

[David Callé]

Fix for #1528618 : translations-dashboard not handling pages without a language

When an english page is missing from the pages list, we still need a time to sort it.

[Daniel Holbach (dholbach)]

LGTM.

review: Approve

[lp:~davidc3/developer-ubuntu-com/translations-dashboard-1528618]

184. By David Callé on 2015-12-22

List only published changes

=== modified file 'translations_dashboard/views.py'
--- translations_dashboard/views.py	2015-10-02 16:59:20 +0000
+++ translations_dashboard/views.py	2015-12-22 16:03:19 +0000
@@ -2,6 +2,8 @@
 from django.template import RequestContext
 from django.views.decorators.cache import never_cache
 from cms.models import CMSPlugin
+import datetime
+import pytz
 
 
 def get_pages():
@@ -13,6 +15,8 @@
         date = plugin_change.changed_date
         lang = plugin_change.language.replace('-', '_')
         page = plugin_change.placeholder.page
+        if not page or page.publisher_is_draft:
+            continue
         path = page.get_path()
         if path not in known_paths:
             known_paths.append(path)
@@ -25,8 +29,10 @@
                         p[lang] = date
                 else:
                     p[lang] = date
+    # When an english page is missing, we still need a time to sort pages
+    notime = datetime.datetime(1, 1, 1, tzinfo=pytz.timezone('UTC'))
     dashboard_data = list(reversed(sorted(
-        dashboard_data, key=lambda k: k.get('en', None))))
+        dashboard_data, key=lambda k: k.get('en', notime))))
     return dashboard_data