Merge lp:~davidagraf/zorba/virtual_destr_auditing into lp:zorba

[David Graf]

remove clang warnings in auditing code

remove clang warnings in auditing code

[David Graf (davidagraf)]

review: Approve

[Till Westmann (tillw)]

review: Approve

[Matthias Brantner (matthias-brantner)]

The destructors should not be defined inlined.

review: Needs Fixing

[lp:~davidagraf/zorba/virtual_destr_auditing]

10977. By David Graf on 2012-08-07

moved definitions of auditing destructors into cpp file

[David Graf (davidagraf)]

Matthias, can you please review it again?

[Matthias Brantner (matthias-brantner)]

review: Approve

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/virtual_destr_auditing-2012-08-14T14-50-08.762Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job virtual_destr_auditing-2012-08-14T14-50-08.762Z is finished. The final status was:

All tests succeeded!

=== modified file 'include/zorba/audit.h'
--- include/zorba/audit.h	2012-07-24 08:48:48 +0000
+++ include/zorba/audit.h	2012-08-07 16:50:34 +0000
@@ -62,6 +62,8 @@
     virtual const Property&    property()    const = 0;
     virtual const String& stringValue() const = 0;
     virtual long long          longValue()   const = 0;
+
+    virtual ~Observation();
   };
 
   class ZORBA_DLL_PUBLIC Configuration {
@@ -81,7 +83,7 @@
 
     virtual std::ostream& write(std::ostream&) const = 0;
     
-    virtual ~Configuration() {}
+    virtual ~Configuration();
   };
 
   class ZORBA_DLL_PUBLIC Record {
@@ -93,6 +95,8 @@
 
     virtual void add(const Property& prop, long long val)          = 0;
     virtual void add(const Property& prop, const String& val) = 0;
+
+    virtual ~Record();
   };
 
   class ZORBA_DLL_PUBLIC Event {
@@ -112,7 +116,7 @@
 
     virtual std::ostream& write(std::ostream&) const = 0;
     
-    virtual ~Event() {}
+    virtual ~Event();
   };
 
   class ZORBA_DLL_PUBLIC Provider {
@@ -122,6 +126,8 @@
 
     virtual Event* createEvent(const Configuration*) = 0;
     virtual void   submitEvent(Event*)               = 0;
+
+    virtual ~Provider();
   };
 
 } /* namespace audit */

=== modified file 'src/api/auditimpl.cpp'
--- src/api/auditimpl.cpp	2012-07-24 08:48:48 +0000
+++ src/api/auditimpl.cpp	2012-08-07 16:50:34 +0000
@@ -116,7 +116,14 @@
 }
 
 //************************************************************************
-// ParameterImpl
+// Observation
+//************************************************************************
+
+Observation::~Observation() {
+}
+
+//************************************************************************
+// ObservationImpl
 //************************************************************************
 
 ObservationImpl::ObservationImpl(const Property& property, long long value)
@@ -146,6 +153,9 @@
 // Configuration
 //************************************************************************
 
+Configuration::~Configuration() {
+}
+
 void Configuration::getPropertyNames(std::vector<String>& names) {
   size_t len = getPropertyCount();
   for (size_t i = 0; i < len; ++i) {
@@ -237,6 +247,13 @@
 }
 
 //************************************************************************
+// Record
+//************************************************************************
+
+Record::~Record() {
+}
+
+//************************************************************************
 // RecordImpl
 //************************************************************************
 
@@ -398,12 +415,22 @@
 // Event
 //************************************************************************
 
+Event::~Event() {
+}
+
 Event*
 Event::get() {
   return &NOP_EVENT_IMPL;
 }
 
 //************************************************************************
+// Provider
+//************************************************************************
+
+Provider::~Provider() {
+}
+
+//************************************************************************
 // ProviderImpl
 //************************************************************************