Merge lp:~david4dev/dmedia/fix-indicator-icons into lp:dmedia

Proposed by David Green
Status: Merged
Merged at revision: 168
Proposed branch: lp:~david4dev/dmedia/fix-indicator-icons
Merge into: lp:dmedia
Diff against target: 39 lines (+9/-2)
2 files modified
dmedia/service.py (+3/-2)
setup.py (+6/-0)
To merge this branch: bzr merge lp:~david4dev/dmedia/fix-indicator-icons
Reviewer Review Type Date Requested Status
Jason Gerard DeRose Approve
Review via email: mp+50819@code.launchpad.net

Description of the change

Fixes the icon problem. I've been unable to test this properly (explained on the bug) but after searching through the code there's nothing to suggest that the small change made could cause any problems or errors.

To post a comment you must log in.
Revision history for this message
Jason Gerard DeRose (jderose) wrote :

Yep, that fixed it. Thanks, David!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dmedia/service.py'
2--- dmedia/service.py 2011-02-21 10:11:32 +0000
3+++ dmedia/service.py 2011-02-22 22:04:33 +0000
4@@ -1,6 +1,7 @@
5 # Authors:
6 # Jason Gerard DeRose <jderose@novacut.com>
7 # Manish SInha <mail@manishsinha.net>
8+# David Green <david4dev@gmail.com>
9 #
10 # dmedia: distributed media library
11 # Copyright (C) 2010 Jason Gerard DeRose <jderose@novacut.com>
12@@ -53,8 +54,8 @@
13 log = logging.getLogger()
14
15
16-ICON = '/usr/share/pixmaps/dmedia/indicator-rendermenu.svg'
17-ICON_ATT = '/usr/share/pixmaps/dmedia/indicator-rendermenu-att.svg'
18+ICON = 'indicator-rendermenu'
19+ICON_ATT = 'indicator-rendermenu-att'
20
21
22 class DMedia(dbus.service.Object):
23
24=== modified file 'setup.py'
25--- setup.py 2011-02-21 10:11:32 +0000
26+++ setup.py 2011-02-22 22:04:33 +0000
27@@ -149,6 +149,12 @@
28 'data/indicator-rendermenu-att.svg',
29 ]
30 ),
31+ ('share/icons/hicolor/scalable/status/',
32+ [
33+ 'data/indicator-rendermenu.svg',
34+ 'data/indicator-rendermenu-att.svg',
35+ ]
36+ ), #enables status icons to be referenced by icon name
37 ('share/dbus-1/services', ['data/org.freedesktop.DMedia.service']),
38 ('lib/dmedia', ['dmedia-service']),
39 ],

Subscribers

People subscribed via source and target branches

to all changes: