Merge lp:~david-goetz/swift/obj_aud_invalid_hash into lp:swift/1.2

[David Goetz]

ObjectAuditor bug with invalidate hash location

[Mike Barton (redbo)]

Looks good enough to merge.

For when this is re-proposed for 1.3... pep8 requires that blank line in the imports, and "renamer_path" and "object_dir" seem to hold the same thing, so you can probably get rid of one.

=== modified file 'swift/obj/auditor.py'
--- swift/obj/auditor.py	2011-01-21 01:05:44 +0000
+++ swift/obj/auditor.py	2011-03-05 00:26:18 +0000
@@ -15,9 +15,10 @@
 
 import os
 import time
+import uuid
+import errno
 from hashlib import md5
 from random import random
-
 from swift.obj import server as object_server
 from swift.obj.replicator import invalidate_hash
 from swift.common.utils import get_logger, renamer, audit_location_generator, \
@@ -140,10 +141,17 @@
             self.quarantines += 1
             self.logger.error(_('ERROR Object %(obj)s failed audit and will '
                 'be quarantined: %(err)s'), {'obj': path, 'err': err})
-            invalidate_hash(os.path.dirname(path))
+            object_dir = os.path.dirname(path)             
+            invalidate_hash(os.path.dirname(object_dir))
             renamer_path = os.path.dirname(path)
-            renamer(renamer_path, os.path.join(self.devices, device,
-                'quarantined', 'objects', os.path.basename(renamer_path)))
+            to_path =  os.path.join(self.devices, device, 'quarantined', 
+                                    'objects', os.path.basename(renamer_path))
+            try:
+                renamer(renamer_path, to_path)
+            except OSError, e:
+                if e.errno == errno.EEXIST:
+                    to_path = "%s-%s" % (to_path, uuid.uuid4().hex)
+                    renamer(renamer_path, to_path)
             return
         except Exception:
             self.errors += 1