Code review comment for lp:~david-cormier-j/sale-wkfl/sale_landed_costs

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi David,

Thanks for porting this module. A few remarks:

 * Would you please consider using the BZR extractor (https://launchpad.net/bazaar-extractor) to put this module in that branch ? This will then keep the commite message insead of having just one commit that add the module. This seems fair on order to keep the author's work.

 * Then, it deserve a bit of PEP8 formatting

Regards,

Joël

review: Needs Fixing (code review, no tests)

« Back to merge proposal