Merge lp:~davewalker/ubuntu/natty/munin/uppercase-hostname-mismatch into lp:ubuntu/natty/munin

Proposed by Dave Walker
Status: Merged
Merge reported by: Daniel Holbach
Merged at revision: not available
Proposed branch: lp:~davewalker/ubuntu/natty/munin/uppercase-hostname-mismatch
Merge into: lp:ubuntu/natty/munin
Diff against target: 58 lines (+38/-0)
3 files modified
debian/changelog (+9/-0)
debian/patches/series (+1/-0)
debian/patches/uppercase-hostname-mismatch.patch (+28/-0)
To merge this branch: bzr merge lp:~davewalker/ubuntu/natty/munin/uppercase-hostname-mismatch
Reviewer Review Type Date Requested Status
Ubuntu Sponsors Pending
Review via email: mp+47391@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-10-15 14:16:41 +0000
3+++ debian/changelog 2011-01-25 13:47:10 +0000
4@@ -1,3 +1,12 @@
5+munin (1.4.5-3ubuntu2) natty; urgency=low
6+
7+ * debian/patches/uppercase-hostname-mismatch.patch: Correctly match the
8+ hostnames in munin-node, fixing a mismatch when the hostname contains
9+ an uppercase character, resolving the failed discovery of plugins to
10+ match. Patch courtesy of upstream svn trunk. (LP: #707099)
11+
12+ -- Dave Walker (Daviey) <DaveWalker@ubuntu.com> Tue, 25 Jan 2011 13:31:14 +0000
13+
14 munin (1.4.5-3ubuntu1) natty; urgency=low
15
16 * Merge from debian unstable. (LP: #661505) Remaining changes:
17
18=== modified file 'debian/patches/series'
19--- debian/patches/series 2010-10-15 14:16:41 +0000
20+++ debian/patches/series 2011-01-25 13:47:10 +0000
21@@ -3,3 +3,4 @@
22 102-snort-bashism.patch
23 103-ejabberd-cli.patch
24 237-hddtemp_smartctl-sata-detect.patch
25+uppercase-hostname-mismatch.patch
26
27=== added file 'debian/patches/uppercase-hostname-mismatch.patch'
28--- debian/patches/uppercase-hostname-mismatch.patch 1970-01-01 00:00:00 +0000
29+++ debian/patches/uppercase-hostname-mismatch.patch 2011-01-25 13:47:10 +0000
30@@ -0,0 +1,28 @@
31+Description: Correctly match the hostnames in munin-node, fixing a mismatch
32+ when the hostname contains an uppercase character, resolving the failed
33+ discovery of plugins to match.
34+Origin: Cherry picked from upstream svn trunk, subset of changeset 3404.
35+Bug: http://munin-monitoring.org/ticket/952
36+Bug-Ubuntu: https://launchpad.net/bugs/707099
37+--- a/node/lib/Munin/Node/Server.pm
38++++ b/node/lib/Munin/Node/Server.pm
39+@@ -88,6 +88,10 @@
40+ my $node = $config->{sconf}{$service}{host_name}
41+ || (split /\s+/, ($host_name || ''))[1]
42+ || $config->{fqdn};
43++
44++ # hostname checks are case in-sensitive,
45++ # so store everything in lowercase
46++ $node = lc($node);
47+
48+ # hostname checks are case insensitive, so store everything in lowercase
49+ $node = lc($node);
50+@@ -171,7 +175,7 @@
51+
52+ logger ("DEBUG: Running command \"$_\".") if $config->{DEBUG};
53+ if (/^list\s*([0-9a-zA-Z\.\-]+)?/i) {
54+- _list_services($session, $1);
55++ _list_services($session, lc($1));
56+ }
57+ elsif (/^cap\s?(.*)/i) {
58+ _negotiate_session_capabilities($session, $1);

Subscribers

People subscribed via source and target branches

to all changes: