lp:~dave-cheney/pyjuju/go-environment-watcher
- Get this branch:
- bzr branch lp:~dave-cheney/pyjuju/go-environment-watcher
Branch merges
- Juju Engineering: Pending requested
-
Diff: 207 lines (+132/-10)4 files modifiedstate/machine.go (+0/-4)
state/state.go (+12/-1)
state/watcher.go (+71/-5)
state/watcher_test.go (+49/-0)
Branch information
Recent revisions
- 154. By William Reade
-
Implement unit-get command
Note that "smart" output formatting no longer exists; we default to yaml.
Also consolidated common test code.
R=niemeyer
CC=
https://codereview. appspot. com/6174051 - 153. By Dave Cheney
-
state: add WatchMachines
R=fwereade, rog, TheMue, niemeyer
CC=
https://codereview. appspot. com/6202060 - 152. By William Reade
-
Add hopefully-reusable --output and --format flags to config-get
Format defaults to "smart", as in python, but does not produce the same
output: it produces go-specific stringifications rather than python-specific
ones. Since "smart" python output was clearly never intended to be (easily)
machine-readable (or it would have used repr) this has been agreed to be
equivalent enough.R=rog, niemeyer
CC=
https://codereview. appspot. com/6165044 - 151. By William Reade
-
Basic config-get command
Note that the command's output is wrong: it's enough to demonstrate that the
right data is being found and used, but that's all. Expect output formatting
more like python in a followup branch.R=rog, niemeyer
CC=
https://codereview. appspot. com/6163044 - 150. By William Reade
-
jujuc client executable
R=rog, niemeyer
CC=
https://codereview. appspot. com/6124051 - 149. By William Reade
-
Newlines in command help messages are now consistent
R=TheMue, rog
CC=
https://codereview. appspot. com/6184044 - 148. By William Reade
-
Tidy up jujud agents
* --session-file is made obsolete by the state/presence package, and has
been removed.
* apart from that deliberate change, functionality should be unaffected.
* agentConf became public and lost its Command methods: it now supplies
addFlags and checkArgs methods, which are used by individual agents in
their own Init methods. This follows the pattern established by cmd.Log
and eliminates the slightly awkward inversion of flagset handling in the
cmd/jujud package, at the cost of having to implement an explicit Init
method on ProvisioningAgent.
* contents of flag.go moved into agent.go; neither was big enough to justify
independent existence.R=rog, niemeyer
CC=
https://codereview. appspot. com/6137043 - 146. By William Reade
-
Implement juju-log command
Inspired by comments on go-jujuc-server, this involved changing
server.Context to expose GetCommand rather than a Log method (which has
moved to the new JujuLogCommand type).R=rog, niemeyer
CC=
https://codereview. appspot. com/6129053
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:pyjuju