lp:~dave-cheney/juju-core/trunk

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:~juju/juju-core/trunk

The Go Language Gophers: Pending requested 2012-11-20

Diff: 45 lines (+5/-5)

2 files modified

version/version.go (+1/-1)
worker/firewaller/firewaller.go (+4/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1080979: FAILURE: store: store_test.go:415

Undecided

Fix Released

Link a bug report

Related blueprints

827. By Dave Cheney on 2013-01-13

gofmt

826. By Dave Cheney on 2013-01-13

set development version to 1.9.7

825. By Roger Peppe on 2013-01-11

various: use agent package, lose agent flags

Unfortunate circular dependencies mean this
comes in one big lump.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7102043

824. By Roger Peppe on 2013-01-11

environs/cloudinit: refactor tests

In an upcoming CL, I was starting to add ever more
logic to the script tests, and a different approach seemed
like a better way.

By specifying the entire script in the tests, we
get a much better idea of what the cloudinit
scripts will look like as a whole, making it
easier to diagnose problems earlier.

The down side is we'll need to change the tests
more often, but they're easier to change, and
it seems like less smoke and mirrors.

R=fwereade, TheMue
CC=
https://codereview.appspot.com/6963050

823. By William Reade on 2013-01-11

jujud: more robust test

TestHostUnits was sometimes panicing with a nil state pointer in
waitDeployedUnits; now it shouldn't.

R=rog, dimitern
CC=
https://codereview.appspot.com/7094043

822. By William Reade on 2013-01-11

uniter: set JUJU_REMOTE_UNIT

see lp:1098442

R=rog, TheMue
CC=
https://codereview.appspot.com/7091043

821. By Roger Peppe on 2013-01-10

environs/agent: new package

For the moment, it only deals with settings, but some
functionality will probably move from environs/tools.go
into this package in a future CL.

I decided to write all the settings to a single file rather than the
current multiple files) because it's less code, more easily extensible,
and if we do want different goroutines in an agent to write different
aspects of the file, it would be straightforward to add some locking
around the write.

R=TheMue, fwereade
CC=
https://codereview.appspot.com/7064066

820. By William Reade on 2013-01-10

charm: don't check hook names

This would break on encountering charms with valid juju-* relation hooks

R=rog, TheMue
CC=
https://codereview.appspot.com/7080043

819. By William Reade on 2013-01-10

charm: juju-* relation names sometimes allowed

Specifically: container-scoped require relations of subordinate charms may
use juju-* names for relations; they're disallowed for everything else.

R=TheMue, rog
CC=
https://codereview.appspot.com/7073056

818. By William Reade on 2013-01-10

cmd/juju: destroy-unit is more restrictive

It now only accepts Alive (because allowing only a single destroy per entity
is already conventional) principal (because subordinate lifecycle is
controlled by the principal) units.

R=TheMue, dimitern, rog
CC=
https://codereview.appspot.com/7058061