lp:~dave-cheney/juju-core/go-cmd-jujud-provisioner-peridodic-provider-check

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:~juju/juju-core/trunk

The Go Language Gophers: Pending requested 2012-06-20

Diff: 102 lines (+44/-5)

1 file modified

cmd/jujud/provisioning.go (+44/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

240. By Dave Cheney on 2012-06-20

wip

239. By Roger Peppe on 2012-06-19

cmd/jujud: remove dummy environ import from provisioning agent

This was causing jujud to panic when run in the cloud.

R=fwereade, dfc, niemeyer
CC=
https://codereview.appspot.com/6295101

238. By Roger Peppe on 2012-06-19

state: remove error return from IsPrincipal

It can no longer fail.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6302089

237. By Roger Peppe on 2012-06-19

environs/ec2: fixes from go vet checking

There are also some other fixes suggested:

state/topology.go:72:2: struct field tag "relation-role" not compatible with reflect.StructTag.Get
state/topology.go:73:2: struct field tag "relation-name" not compatible with reflect.StructTag.Get
store/store.go:122:5: struct field tag "_id" not compatible with reflect.StructTag.Get
store/store.go:123:5: struct field tag "t" not compatible with reflect.StructTag.Get

I wonder if we should use the standard tag format for these
tags (`yaml:"relation-role"`).

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6301080

236. By Dave Cheney on 2012-06-19

cmd/jujud: provisioner shuts down unknown instances

This proposal adds the facility for the PA to detect lost or
unknown instances running in the environment that are not
associated with a machine in the state and shut them down.

R=
CC=
https://codereview.appspot.com/6315043

235. By William Reade on 2012-06-19

trivial: MachinesWatcher and MachineUnitsWatcher now send initial values.

R=rog
CC=
https://codereview.appspot.com/6295100

234. By William Reade on 2012-06-19

trivial: remove unwanted code on inappropriate goroutine

R=
CC=
https://codereview.appspot.com/6308089

233. By Dave Cheney on 2012-06-19

cmd/jujud: provisioner can now start and stop instances

This branch adds the ability for the provisioning agent to
start and stop instances according to changes in state.

To be implemented in a later branch is the ability for the PA
to reconcile the set of instances running with the set of
instances known to the state.

R=rog, niemeyer
CC=
https://codereview.appspot.com/6294066

232. By Frank Mueller on 2012-06-18

state: Rework of the errors in machine.go.

Next step in the reworking process of the state errors,
this time the file machine.go.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6304084

231. By William Reade on 2012-06-18

Add RelationRole.CounterpartRole

Since niemeyer said he didn't mind for now, I thought I'd propose this
alone; and if/when we do turn out to need fancy new roles which don't have
counterparts, we can always get rid of this, and it will still hopefully help
us find the bits we need to fix if and when that happens.

R=niemeyer
CC=
https://codereview.appspot.com/6308084