lp:~dave-cheney/juju-core/go-cmd-jujud-machine-machiner

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:~juju/juju-core/trunk

The Go Language Gophers: Pending requested 2012-07-03

Diff: 532 lines (+251/-227)

4 files modified

cmd/jujud/machine.go (+0/-75)
cmd/jujud/machine_test.go (+0/-152)
cmd/jujud/machiner.go (+79/-0)
cmd/jujud/machiner_test.go (+172/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

281. By Dave Cheney on 2012-07-03

Split machine.go to machine and machiner

280. By Dave Cheney on 2012-07-03

service/provisioner: new package

This proposal moves the Provisioner to a new package so it can
be imported by commands (jujud etc) and other packages
(environs/jujutest).

note:

* MachinerAgent/Machiner will be handled in a following branch.

* suite_test.go is duplicated for the moment, once Williams test
refactor is completed, this duplication will be removed.

R=niemeyer
CC=
https://codereview.appspot.com/6344071

279. By Dave Cheney on 2012-07-03

cmd/jujud: bifurcate Provisioniner and Provisioner

This proposal prepares for the move of the Provisioner into
juju-core/services/provisioner by moving it into its own file.

R=niemeyer
CC=
https://codereview.appspot.com/6350064

278. By Dave Cheney on 2012-07-03

cmd/juju: enable deploy command

William tells me this was an inadvertent oversight.

R=niemeyer
CC=
https://codereview.appspot.com/6350049

277. By Dave Cheney on 2012-06-30

environs/ec2: return matching ami for the region

Using defaultInstanceConstraints always specified us-east-1 when
searching for the instance ami. This branch respects the region
setting from the configuration.

R=niemeyer
CC=
https://codereview.appspot.com/6362043

276. By Frank Mueller on 2012-06-29

watcher: renamed the fields Deleted to Removed

Several watcher return a struct containing two fields
for added and removed subnodes or other informations
inside a node content. The name of the field for
removed informations has been inconsistent. Now all
are changed into the identifier "Removed".

R=niemeyer
CC=
https://codereview.appspot.com/6351047

275. By Frank Mueller on 2012-06-28

state: added watcher for service units

The added watcher returns informations about the
assigned or unassigned units of a service.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6325062

274. By Aram Hăvărneanu on 2012-06-28

mstate: basic service units

R=niemeyer
CC=
https://codereview.appspot.com/6346044

273. By William Reade on 2012-06-28

Watcher consistency improvements

* watcher fields that have no business being fields have been removed
* watcher stoppage has been consolidated
* handling of inappropriately closed watcher channels has been consolidated
* garbage watchers in cmd/jujud are now stopped explicitly
* significant code duplication removed from state/watcher.go

As a result of the final point, it has become apparent that most of the
watchers in the state package are at risk of emitting inappropriate events
that don't correspond to real changes. The fact that this is now apparent,
when it had previously been missed by every previous reviewer, is IMO a
strong indication that this change is a good move.

I haven't started to address that issue, however, because the CL is already
big enough.

R=niemeyer
CC=
https://codereview.appspot.com/6347045

272. By William Reade on 2012-06-28

Add Version field to ContentChange

As discussed on IRC. One notable consequence is that the ContentWatcher now
fires on version changes that don't involve a content change; this is not
a big deal, because we shouldn't be writing to nodes in the first place if
their state has not changed; and if that does ever happen the only result
should be to reestablish some state that was in fact already established.

R=niemeyer
CC=
https://codereview.appspot.com/6330053