Code review comment for lp:~dave-cheney/juju-core/167-simplestreams-add-trusty

The attempt to merge lp:~dave-cheney/juju-core/167-simplestreams-add-trusty into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core 0.015s
ok launchpad.net/juju-core/agent 0.659s
ok launchpad.net/juju-core/agent/tools 0.211s
ok launchpad.net/juju-core/bzr 6.781s
ok launchpad.net/juju-core/cert 3.407s
ok launchpad.net/juju-core/charm 0.531s
? launchpad.net/juju-core/charm/hooks [no test files]
? launchpad.net/juju-core/charm/testing [no test files]
ok launchpad.net/juju-core/cloudinit 0.047s
ok launchpad.net/juju-core/cloudinit/sshinit 1.123s
ok launchpad.net/juju-core/cmd 0.224s
ok launchpad.net/juju-core/cmd/charm-admin 0.840s
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 241.684s
ok launchpad.net/juju-core/cmd/jujud 61.775s
ok launchpad.net/juju-core/cmd/plugins/juju-metadata 8.494s
? launchpad.net/juju-core/cmd/plugins/juju-restore [no test files]
ok launchpad.net/juju-core/constraints 0.026s
ok launchpad.net/juju-core/container 0.037s
ok launchpad.net/juju-core/container/factory 0.051s
ok launchpad.net/juju-core/container/kvm 0.302s
ok launchpad.net/juju-core/container/kvm/mock 0.037s
? launchpad.net/juju-core/container/kvm/testing [no test files]
ok launchpad.net/juju-core/container/lxc 0.264s
? launchpad.net/juju-core/container/lxc/mock [no test files]
? launchpad.net/juju-core/container/lxc/testing [no test files]
? launchpad.net/juju-core/container/testing [no test files]
ok launchpad.net/juju-core/downloader 5.291s
ok launchpad.net/juju-core/environs 3.256s
ok launchpad.net/juju-core/environs/bootstrap 4.614s
ok launchpad.net/juju-core/environs/cloudinit 0.625s
ok launchpad.net/juju-core/environs/config 3.122s
ok launchpad.net/juju-core/environs/configstore 0.056s
ok launchpad.net/juju-core/environs/filestorage 0.032s
ok launchpad.net/juju-core/environs/httpstorage 1.037s
ok launchpad.net/juju-core/environs/imagemetadata 0.727s
? launchpad.net/juju-core/environs/imagemetadata/testing [no test files]
ok launchpad.net/juju-core/environs/instances 0.060s
ok launchpad.net/juju-core/environs/jujutest 0.274s
ok launchpad.net/juju-core/environs/manual 10.874s

----------------------------------------------------------------------
FAIL: simplestreams_test.go:410: simplestreamsSuite.TestSupportedSeries

simplestreams_test.go:415:
    c.Assert(series, gc.DeepEquals, coretesting.SupportedSeries)
... obtained []string = []string{"precise", "quantal", "raring", "saucy"}
... expected []string = []string{"precise", "quantal", "raring", "saucy", "trusty"}

OOPS: 45 passed, 1 FAILED
--- FAIL: Test (0.10 seconds)
FAIL
FAIL launchpad.net/juju-core/environs/simplestreams 0.346s
? launchpad.net/juju-core/environs/simplestreams/testing [no test files]
ok launchpad.net/juju-core/environs/sshstorage 1.093s
ok launchpad.net/juju-core/environs/storage 1.182s
ok launchpad.net/juju-core/environs/sync 34.013s
ok launchpad.net/juju-core/environs/testing 0.235s
ok launchpad.net/juju-core/environs/tools 6.950s
? launchpad.net/juju-core/environs/tools/testing [no test files]
ok launchpad.net/juju-core/errors 0.016s
ok launchpad.net/juju-core/instance 0.023s
? launchpad.net/juju-core/instance/testing [no test files]
ok launchpad.net/juju-core/juju 20.953s
ok launchpad.net/juju-core/juju/osenv 0.035s
? launchpad.net/juju-core/juju/testing [no test files]
ok launchpad.net/juju-core/log 0.020s
ok launchpad.net/juju-core/log/syslog 0.022s
ok launchpad.net/juju-core/names 0.028s
? launchpad.net/juju-core/provider [no test files]
? launchpad.net/juju-core/provider/all [no test files]
ok launchpad.net/juju-core/provider/azure 6.402s
ok launchpad.net/juju-core/provider/common 5.423s
ok launchpad.net/juju-core/provider/dummy 24.208s
ok launchpad.net/juju-core/provider/ec2 21.412s
ok launchpad.net/juju-core/provider/joyent 5.298s
ok launchpad.net/juju-core/provider/local 5.939s
ok launchpad.net/juju-core/provider/maas 22.902s
ok launchpad.net/juju-core/provider/manual 1.675s
ok launchpad.net/juju-core/provider/openstack 43.450s
ok launchpad.net/juju-core/replicaset 45.129s
ok launchpad.net/juju-core/rpc 0.087s
ok launchpad.net/juju-core/rpc/jsoncodec 0.047s
? launchpad.net/juju-core/rpc/rpcreflect [no test files]
ok launchpad.net/juju-core/schema 0.033s
ok launchpad.net/juju-core/state 83.449s
ok launchpad.net/juju-core/state/api 1.884s
ok launchpad.net/juju-core/state/api/agent 1.940s
? launchpad.net/juju-core/state/api/base [no test files]
ok launchpad.net/juju-core/state/api/charmrevisionupdater 1.496s
? launchpad.net/juju-core/state/api/common [no test files]
? launchpad.net/juju-core/state/api/common/testing [no test files]
ok launchpad.net/juju-core/state/api/deployer 6.009s
ok launchpad.net/juju-core/state/api/environment 1.877s
ok launchpad.net/juju-core/state/api/firewaller 10.709s
ok launchpad.net/juju-core/state/api/keymanager 3.415s
ok launchpad.net/juju-core/state/api/keyupdater 2.726s
ok launchpad.net/juju-core/state/api/logger 2.243s
ok launchpad.net/juju-core/state/api/machiner 3.249s
ok launchpad.net/juju-core/state/api/params 0.034s
ok launchpad.net/juju-core/state/api/provisioner 9.475s
ok launchpad.net/juju-core/state/api/uniter 27.933s
ok launchpad.net/juju-core/state/api/upgrader 3.888s
ok launchpad.net/juju-core/state/api/watcher 3.320s
ok launchpad.net/juju-core/state/apiserver 7.790s
ok launchpad.net/juju-core/state/apiserver/agent 2.992s
ok launchpad.net/juju-core/state/apiserver/charmrevisionupdater 2.502s
? launchpad.net/juju-core/state/apiserver/charmrevisionupdater/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/client 44.359s
ok launchpad.net/juju-core/state/apiserver/common 2.008s
? launchpad.net/juju-core/state/apiserver/common/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/deployer 4.743s
ok launchpad.net/juju-core/state/apiserver/environment 1.502s
ok launchpad.net/juju-core/state/apiserver/firewaller 5.952s
ok launchpad.net/juju-core/state/apiserver/keymanager 4.115s
? launchpad.net/juju-core/state/apiserver/keymanager/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/keyupdater 3.035s
ok launchpad.net/juju-core/state/apiserver/logger 3.582s
ok launchpad.net/juju-core/state/apiserver/machine 3.050s
ok launchpad.net/juju-core/state/apiserver/provisioner 11.518s
? launchpad.net/juju-core/state/apiserver/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/uniter 19.424s
ok launchpad.net/juju-core/state/apiserver/upgrader 5.751s
ok launchpad.net/juju-core/state/multiwatcher 0.760s
ok launchpad.net/juju-core/state/presence 6.409s
ok launchpad.net/juju-core/state/statecmd 1.932s
? launchpad.net/juju-core/state/testing [no test files]
ok launchpad.net/juju-core/state/watcher 5.613s
ok launchpad.net/juju-core/store 18.415s
ok launchpad.net/juju-core/testing 1.342s
ok launchpad.net/juju-core/testing/checkers 0.022s
ok launchpad.net/juju-core/testing/testbase 0.019s
ok launchpad.net/juju-core/thirdparty/pbkdf2 0.126s
ok launchpad.net/juju-core/tools 0.027s
ok launchpad.net/juju-core/upgrades 0.039s
ok launchpad.net/juju-core/upstart 0.152s
ok launchpad.net/juju-core/utils 2.402s
ok launchpad.net/juju-core/utils/exec 0.035s
ok launchpad.net/juju-core/utils/fslock 0.905s
ok launchpad.net/juju-core/utils/parallel 0.943s
ok launchpad.net/juju-core/utils/set 0.024s
ok launchpad.net/juju-core/utils/ssh 20.794s
? launchpad.net/juju-core/utils/ssh/testing [no test files]
ok launchpad.net/juju-core/utils/tailer 1.001s
ok launchpad.net/juju-core/version 0.062s
ok launchpad.net/juju-core/worker 6.625s
ok launchpad.net/juju-core/worker/authenticationworker 2.990s
ok launchpad.net/juju-core/worker/charmrevisionworker 2.244s
ok launchpad.net/juju-core/worker/cleaner 1.297s
ok launchpad.net/juju-core/worker/deployer 3.960s
ok launchpad.net/juju-core/worker/firewaller 12.362s
ok launchpad.net/juju-core/worker/instancepoller 2.225s
ok launchpad.net/juju-core/worker/localstorage 0.052s
ok launchpad.net/juju-core/worker/logger 1.475s
ok launchpad.net/juju-core/worker/machineenvironmentworker 7.625s
ok launchpad.net/juju-core/worker/machiner 3.369s
ok launchpad.net/juju-core/worker/minunitsworker 1.306s
ok launchpad.net/juju-core/worker/provisioner 35.311s
ok launchpad.net/juju-core/worker/resumer 1.566s
ok launchpad.net/juju-core/worker/terminationworker 0.062s
ok launchpad.net/juju-core/worker/uniter 209.051s
ok launchpad.net/juju-core/worker/uniter/charm 3.730s
ok launchpad.net/juju-core/worker/uniter/debug 1.113s
ok launchpad.net/juju-core/worker/uniter/hook 0.018s
ok launchpad.net/juju-core/worker/uniter/jujuc 0.484s
ok launchpad.net/juju-core/worker/uniter/relation 1.404s
ok launchpad.net/juju-core/worker/upgrader 5.112s

warning: building out-of-date packages:
 launchpad.net/lpad
 launchpad.net/goose/testservices/hook
 launchpad.net/goose/testservices/identityservice
 launchpad.net/goose/testservices
 launchpad.net/goose/testservices/novaservice
 launchpad.net/goose/testservices/swiftservice
 launchpad.net/goose/testservices/openstackservice
installing these packages with 'go test -i ./...' will speed future tests.