juju-core

Merge lp:~dave-cheney/juju-core/165-log-handleboostrap-error into lp:~go-bot/juju-core/trunk

  1. 165-log-handleboostrap-error
  2. Merge into trunk
Proposed by Dave Cheney
Status: Merged
Approved by: Dave Cheney
Approved revision: no longer in the source branch.
Merged at revision: 2127
Proposed branch: lp:~dave-cheney/juju-core/165-log-handleboostrap-error
Merge into: lp:~go-bot/juju-core/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
provider/common/bootstrap.go (+1/-0)
To merge this branch: bzr merge lp:~dave-cheney/juju-core/165-log-handleboostrap-error
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+197984@code.launchpad.net

Commit message

provider/common: always log bootstrap failure

Fixes LP #1258246

Description of the change

provider/common: always log bootstrap failure

Fixes LP #1258246

https://codereview.appspot.com/38150043/

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

LGTM

https://codereview.appspot.com/38150043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'provider/common/bootstrap.go'
2--- provider/common/bootstrap.go 2013-12-03 05:20:25 +0000
3+++ provider/common/bootstrap.go 2013-12-06 02:10:51 +0000
4@@ -85,6 +85,7 @@
5 if err == nil {
6 return
7 }
8+ logger.Errorf("bootstrap failed: %v", err)
9 ctx.SetInterruptHandler(func() {
10 fmt.Fprintln(ctx.Stderr, "Cleaning up failed bootstrap")
11 })

Subscribers

People subscribed via source and target branches

to status/vote changes: