lp:~dave-cheney/juju-core/110-remove-instance-newaddresses

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:~go-bot/juju-core/trunk

Juju Engineering: Pending requested 2014-04-01

Diff: 21 lines (+5/-3)

1 file modified

state/apiserver/firewaller/firewaller_test.go (+5/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2523. By Dave Cheney on 2014-04-01

Fixes LP 1300538

Compare the result as a set, not an ordered list. If the results of the watch are supposed to be in order, then the code itself is broken.

2522. By Dave Cheney on 2014-03-31

[r=dave-cheney],[bug=1298770] unit.SetAddress now takes a vararg

Update LP#1298770

The previous branch updated instance.NewAddress to be varargs and demonstated that most callers of NewAddresses were used to get a slice of addresses so they could pass them to unit.SetAddresses. By making SetAddresses vararg NewAddresses is unneeded. This will be the next change.

https://codereview.appspot.com/82390045/

2521. By Wayne Witzel III on 2014-03-31

[r=wwitzel3] agent/mongo: added MongoSelectPeerAddress

Use this method to ensure that we get the same selection behavior in many
places. Including API calls, replicaset worker, and bootstrap state.

https://codereview.appspot.com/82550043/

2520. By Andrew Wilkins on 2014-03-31

[r=axwalk] state/api: dial info.Addrs in parallel

This change is to dial all addresses in
parallel. The first one that successfully
connects is used.

https://codereview.appspot.com/82450043/

2519. By Andrew Wilkins on 2014-03-31

[r=axwalk] Initialise APIHostPorts during bootstrap

jujud bootstrap-state is updated to query
the provider for the instance's addresses
and store them in state. Additionally,
State.SetAPIHostPorts is called with those
addresses and the API server port defined
in agent.conf.

https://codereview.appspot.com/82500044/

2518. By Andrew Wilkins on 2014-03-31

[r=axwalk] agent: add ConfigSetterOnly.SetAPIHostPorts

We still only store addresses in the config,
so we lose some metadata. We make use of the
scope metadata before storing, though, to
prune the addresses to the internal ones.

https://codereview.appspot.com/82520043/

2517. By Andrew Wilkins on 2014-03-31

[r=axwalk] Cache API server addresses in .jenv

We now return API server addresses from
the Login API, and cache those addresses
in the client's configstore. If the client
connects using environments.yaml, then it
is expected to get updated addresses from
provider-state.

https://codereview.appspot.com/81780043/

2516. By Ian Booth on 2014-03-31

[r=wallyworld] Improve ssh.ReplaceKeys

ReplaceKeys is used by the authentication worker
to write ssh keys to ~/.ssh/authorized_keys. It
merges existing keys with those added to Juju. It
checks that all keys to be written have comments, but
existing keys may not have comments. The check for key
comment is done as any keys are added to Juju so the
check in ReplaceKeys can be removed.

https://codereview.appspot.com/82480043/

2515. By Ian Booth on 2014-03-31

[r=wallyworld],[bug=1221798] Remove obsolete Public/PrivateAddress methods

The PublicAddress() and PrivateAddress() methods
on environs.EnvironProvider are no longer needed
since units now get their addresses from their
assigned machine, and these addresses are
updated by the instance poller.

Extra logic was required to allow the existing
machineAddresses method to be able to handle
subordinate units.

This work allows the Joyent provider to be
enabled. Smoke tested by hand on Joyent, local,
EC2, HP CLoud and Azure: bootstrap environment,
deploy a unit or two and check status. For
Joyent, do a little more testing and ensure
wordpress works.

https://codereview.appspot.com/82470043/

2514. By Dimiter Naydenov on 2014-03-31

[r=dimitern] cmd/juju: Add --(exclude-)networks args to deploy

Implemented two new arguments to juju deploy:
--networks and --exclude-networks. They allow specifying
networks to enable/disable when deploying new machines
hosting units of the service.

If the API server is older than 1.17.7 and does not
support ServiceDeployWithNetworks, and networks are
specified, an error is returned. Otherwise (without
networks specified), the command falls back to using
ServiceDeploy API.

https://codereview.appspot.com/80600044/

R=jameinel