lp:~dave-cheney/juju-core/089-state-unit-assigned-machine

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:~juju/juju-core/trunk

The Go Language Gophers: Pending requested 2012-09-04

Diff: 247 lines (+38/-42)

8 files modified

cmd/juju/status.go (+2/-2)
cmd/jujud/provisioning_test.go (+1/-3)
juju/deploy_test.go (+5/-5)
state/assign_test.go (+18/-18)
state/service_test.go (+2/-2)
state/unit.go (+6/-6)
worker/firewaller/firewaller.go (+3/-3)
worker/firewaller/firewaller_test.go (+1/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

457. By Dave Cheney on 2012-09-04

AssignedMachine

456. By Roger Peppe on 2012-09-03

juju: always connect to State.

All uses of juju.Conn other than Bootstrap and Destroy require a state
connection, so make State an exported field of Conn and connect to it
when creating the Conn.

The few places that call Bootstrap can easily call Environ.Bootstrap
instead.

Also add environs.NewFromName to make it easier to open an
environment, rename juju.NewConn to juju.NewConnFromName, and add
juju.NewConnFromEnviron to join the dots.

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6488077

455. By Roger Peppe on 2012-08-31

worker: new package to factor out some common code from workers

Also simplify workers a little.

R=niemeyer
CC=
https://codereview.appspot.com/6501072

454. By Roger Peppe on 2012-08-31

cmd/jujud: fix race in test

We should not call OpenPort until the new instance id has
hit the state.

We also fix a bug in firewaller where it called InstanceId even
when it needed to do nothing, and take the opportunity
to make the firewaller tests a little more concise now that we
have JujuConnSuite.

R=TheMue, dfc
CC=
https://codereview.appspot.com/6499056

453. By Roger Peppe on 2012-08-31

environs: add BootstrapConfig

Also add flags to environs.FindTools and environs.BestTools,
LoggingSuite to JujuSuite, and make the Config in cloudinit
a *config.Config.

R=niemeyer, dfc
CC=
https://codereview.appspot.com/6500052

452. By Frank Mueller on 2012-08-30

state: changed environ config to be config.Config

state.EnvironConfig() and the according watcher now
return environs/config.Config. Additionally the new
function state.SetEnvironConfig() replaces the current
configuration. Depending code - mostly tests - has
been changed.

R=niemeyer
CC=
https://codereview.appspot.com/6493055

451. By William Reade on 2012-08-30

add charm.GitDir

Hopefully uncontroversial; implementing this should help me focus on the
actual charm.Manager implementation more easily.

R=niemeyer
CC=
https://codereview.appspot.com/6493059

450. By Roger Peppe on 2012-08-30

environs/config: add support for agent version.

Also adjust documentation for schema.Omit slightly
and add a test.

R=niemeyer
CC=
https://codereview.appspot.com/6499055

449. By Roger Peppe on 2012-08-30

environs: change BestTools so it does not choose later versions

As discussed on-line, when upgrading we want to
choose the latest version with number <= the proposed
version.

R=niemeyer
CC=
https://codereview.appspot.com/6495054

448. By Dave Cheney on 2012-08-30

environs/dummy: fix build

I thought I ran tests before submitting, but clearly I did not.

R=
CC=
https://codereview.appspot.com/6501063