Go OpenStack Exchange

Merge lp:~dave-cheney/goose/004-fix-fd-leak into lp:goose

  1. 004-fix-fd-leak
  2. Merge into trunk
Proposed by Dave Cheney
Status: Merged
Approved by: Dave Cheney
Approved revision: 87
Merged at revision: 87
Proposed branch: lp:~dave-cheney/goose/004-fix-fd-leak
Merge into: lp:goose
Diff against target: 11 lines (+1/-0)
1 file modified
http/client.go (+1/-0)
To merge this branch: bzr merge lp:~dave-cheney/goose/004-fix-fd-leak
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+159778@code.launchpad.net

Commit message

http: do not leak connections during rate limiting

Discovered during load testing, when goose moved into rate limting mode, the previous response was leaked.

https://codereview.appspot.com/8668048/

Description of the change

http: do not leak connections during rate limiting

Discovered during load testing, when goose moved into rate limting mode, the previous response was leaked.

https://codereview.appspot.com/8668048/

To post a comment you must log in.
lp:~dave-cheney/goose/004-fix-fd-leak updated
87. By Dave Cheney

fix it some more

Revision history for this message
Roger Peppe (rogpeppe) wrote :

On 2013/04/19 09:20:31, dfc wrote:
> Please take a look.

LGTM

https://codereview.appspot.com/8668048/

Revision history for this message
William Reade (fwereade) wrote :

LGTM

https://codereview.appspot.com/8668048/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'http/client.go'
2--- http/client.go 2013-04-17 04:38:44 +0000
3+++ http/client.go 2013-04-19 09:21:25 +0000
4@@ -216,6 +216,7 @@
5 if resp.StatusCode != http.StatusRequestEntityTooLarge || resp.Header.Get("Retry-After") == "" {
6 return resp, nil
7 }
8+ resp.Body.Close()
9 retryAfter, err := strconv.ParseFloat(resp.Header.Get("Retry-After"), 32)
10 if err != nil {
11 return nil, errors.Newf(err, "Invalid Retry-After header %s", URL)

Subscribers

People subscribed via source and target branches