Merge lp:~dashua/light-themes/fix.lp.929651 into lp:~ubuntu-art-pkg/light-themes/trunk

Proposed by James Schriver on 2012-03-06
Status: Merged
Merge reported by: Andrea Cimitan
Merged at revision: not available
Proposed branch: lp:~dashua/light-themes/fix.lp.929651
Merge into: lp:~ubuntu-art-pkg/light-themes/trunk
Diff against target: 41 lines (+12/-4)
2 files modified
Ambiance/gtk-3.0/gtk-widgets.css (+6/-2)
Radiance/gtk-3.0/gtk-widgets.css (+6/-2)
To merge this branch: bzr merge lp:~dashua/light-themes/fix.lp.929651
Reviewer Review Type Date Requested Status
Andrea Cimitan 2012-03-06 Approve on 2012-03-06
Review via email: mp+96039@code.launchpad.net
To post a comment you must log in.
James Schriver (dashua) wrote :

Fix unreadable tooltips in Empathy for Ambiance and Radiance themes.

211. By James Schriver on 2012-03-06

Ambiance/Radiance/gtk-3.0/gtk-widgets.css
 - Fix empathy tooltips. (LP: #929651)

Andrea Cimitan (cimi) wrote :

You added a shadow not requested :) and looking at the code you removed the border with border-style: none

review: Needs Fixing
212. By James Schriver on 2012-03-06

Ambiance/Radiance/gtk-3.0/gtk-widgets.css
 - Re-add border style and remove text shadow not requested

James Schriver (dashua) wrote :

Should be ok now ;)

Andrea Cimitan (cimi) wrote :

I merged a slightly different commit, should fix the internal colorization!
http://bazaar.launchpad.net/~ubuntu-art-pkg/light-themes/trunk/revision/212

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.0/gtk-widgets.css'
2--- Ambiance/gtk-3.0/gtk-widgets.css 2012-03-05 16:50:11 +0000
3+++ Ambiance/gtk-3.0/gtk-widgets.css 2012-03-06 12:10:40 +0000
4@@ -2087,10 +2087,14 @@
5 background-image: -gtk-gradient (radial, center 0, 0, center 0, 0.8,
6 from (alpha (mix (@tooltip_bg_color, #ffffff, 0.2), 0.86)),
7 to (alpha (@tooltip_bg_color, 0.86)));
8- border-color: alpha (#ffffff, 0.2);
9+ border-color: alpha (@tooltip_fg_color, 0.2);
10 border-radius: 5px;
11
12- color: white;
13+ color: @tooltip_fg_color;
14+}
15+
16+.tooltip * {
17+ background-color: alpha(@tooltip_bg_color, 0.90);
18 }
19
20 /************
21
22=== modified file 'Radiance/gtk-3.0/gtk-widgets.css'
23--- Radiance/gtk-3.0/gtk-widgets.css 2012-03-05 16:50:11 +0000
24+++ Radiance/gtk-3.0/gtk-widgets.css 2012-03-06 12:10:40 +0000
25@@ -2074,10 +2074,14 @@
26 background-image: -gtk-gradient (radial, center 0, 0, center 0, 0.8,
27 from (alpha (mix (@tooltip_bg_color, #ffffff, 0.2), 0.86)),
28 to (alpha (@tooltip_bg_color, 0.86)));
29- border-color: alpha (#ffffff, 0.2);
30+ border-color: alpha (@tooltip_fg_color, 0.2);
31 border-radius: 5px;
32
33- color: white;
34+ color: @tooltip_fg_color;
35+}
36+
37+.tooltip * {
38+ background-color: alpha(@tooltip_bg_color, 0.90);
39 }
40
41 /************

Subscribers

People subscribed via source and target branches