Merge lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app/remix
Proposed by
dazza5000
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Andrew Hayzen | ||||
Approved revision: | 853 | ||||
Merged at revision: | 849 | ||||
Proposed branch: | lp:~darran-kelinske/music-app/lp_bug_1428454 | ||||
Merge into: | lp:music-app/remix | ||||
Diff against target: |
146 lines (+75/-1) 4 files modified
MusicPlaylists.qml (+1/-0) common/SongsPage.qml (+2/-0) tests/autopilot/music_app/__init__.py (+24/-0) tests/autopilot/music_app/tests/test_music.py (+48/-1) |
||||
To merge this branch: | bzr merge lp:~darran-kelinske/music-app/lp_bug_1428454 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Andrew Hayzen | Approve | ||
Review via email: mp+253566@code.launchpad.net |
Commit message
* Added a test case for deleting a playlist
Description of the change
Added a test case for deleting a playlist
To post a comment you must log in.
Looks good so far :) Just a few inline comments...
L65, L75, L188 and possibly L140 - Could you remove this extra blank lines? (See PEP8 styling on this [0] - 2 lines for a class def and 1 for a method)
L102 - Is there any reason for renaming this var and method call? Could we keep it as add_to_playlist singular?
As I don't think jenkins runs for non-team members, I've manually run PEP8/pyflakes for you so you can see the errors [1]
0 - https:/ /www.python. org/dev/ peps/pep- 0008/#blank- lines pastebin. ubuntu. com/10629706/
1 - http://