Code review comment for lp:~darkxst/ubuntu/utopic/gnome-settings-daemon/lp1372346

Revision history for this message
Martin Pitt (pitti) wrote :

This mostly looks good to me. There is one removed key though:

--- /usr/share/glib-2.0/schemas/org.gnome.settings-daemon.peripherals.gschema.xml…………………2014-07-10 11:22:10.000000000 +0200
+++ ./usr/share/glib-2.0/schemas/org.gnome.settings-daemon.peripherals.gschema.xml………………2014-09-30 14:40:06.000000000 +0200
@@ -107,10 +107,6 @@
       <summary>NumLock state</summary>
       <description>The remembered state of the NumLock LED.</description>
     </key>
- <key name="input-sources-switcher" enum="org.gnome.settings-daemon.GsdInputSourcesSwitcher">
- <default>'off'</default>
- <summary>Modifiers-only input sources switcher shortcut</summary>
- </key>

together with the removed GsdInputSourcesSwitcher enum in org.gnome.settings-daemon.enums.xml. Is that a concern for backwards compatibility?

review: Needs Information

« Back to merge proposal