Merge lp:~darkxst/ubuntu/saucy/empathy/lp1203955 into lp:~ubuntu-desktop/empathy/ubuntu

Proposed by Tim Lunn
Status: Merged
Approved by: Martin Pitt
Approved revision: 343
Merged at revision: 343
Proposed branch: lp:~darkxst/ubuntu/saucy/empathy/lp1203955
Merge into: lp:~ubuntu-desktop/empathy/ubuntu
Diff against target: 88 lines (+62/-2)
3 files modified
debian/changelog (+7/-2)
debian/patches/series (+1/-0)
debian/patches/ubuntu_launch_uoa_panel.patch (+54/-0)
To merge this branch: bzr merge lp:~darkxst/ubuntu/saucy/empathy/lp1203955
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+176322@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

LGTM, thank you!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-07-22 03:08:58 +0000
3+++ debian/changelog 2013-07-23 04:53:29 +0000
4@@ -1,9 +1,14 @@
5-empathy (3.8.3-0ubuntu4) UNRELEASED; urgency=low
6+empathy (3.8.3-0ubuntu5) UNRELEASED; urgency=low
7
8+ [ Jeremy Bicha ]
9 * debian/control:
10 - Drop gnome-doc-utils and rarian from build-dependencies
11
12- -- Jeremy Bicha <jbicha@ubuntu.com> Sun, 21 Jul 2013 22:47:54 -0400
13+ [ Tim Lunn ]
14+ * debian/patches/ubuntu_launch_uoa_panel.patch:
15+ - Only launch UOA panel when running a Unity session. (LP: #1203955)
16+
17+ -- Tim Lunn <tim@feathertop.org> Tue, 23 Jul 2013 14:40:10 +1000
18
19 empathy (3.8.3-0ubuntu3) saucy; urgency=low
20
21
22=== modified file 'debian/patches/series'
23--- debian/patches/series 2013-05-31 10:25:14 +0000
24+++ debian/patches/series 2013-07-23 04:53:29 +0000
25@@ -9,3 +9,4 @@
26 43_quicklists.patch
27 47_git_activate_with_platform_data.patch
28 include-empathy-keyring.h
29+ubuntu_launch_uoa_panel.patch
30
31=== added file 'debian/patches/ubuntu_launch_uoa_panel.patch'
32--- debian/patches/ubuntu_launch_uoa_panel.patch 1970-01-01 00:00:00 +0000
33+++ debian/patches/ubuntu_launch_uoa_panel.patch 2013-07-23 04:53:29 +0000
34@@ -0,0 +1,54 @@
35+From 906eb708198b655eb04a3eda08cdce58e8558b0c Mon Sep 17 00:00:00 2001
36+From: Tim Lunn <tim@feathertop.org>
37+Date: Tue, 23 Jul 2013 12:30:11 +1000
38+Subject: [PATCH] Check desktop session to determine which accounts panel to
39+ launch
40+
41+---
42+ src/empathy-accounts-dialog.c | 14 ++++++++++----
43+ 1 file changed, 10 insertions(+), 4 deletions(-)
44+
45+diff --git a/src/empathy-accounts-dialog.c b/src/empathy-accounts-dialog.c
46+index a6a45f2..f4ea626 100644
47+--- a/src/empathy-accounts-dialog.c
48++++ b/src/empathy-accounts-dialog.c
49+@@ -2702,8 +2702,9 @@ launch_uoa_panel (TpAccount *selected_account,
50+ g_object_unref (manager);
51+ }
52+
53+-#else /* HAVE_UOA */
54++#endif /* HAVE_UOA */
55+
56++#ifdef HAVE_GOA
57+ static void
58+ launch_empathy_accounts (TpAccount *selected_account,
59+ gboolean if_needed,
60+@@ -2734,7 +2735,7 @@ launch_empathy_accounts (TpAccount *selected_account,
61+
62+ g_string_free (args, TRUE);
63+ }
64+-#endif /* HAVE_UOA */
65++#endif /* HAVE_GOA */
66+
67+ void
68+ empathy_accounts_dialog_show_application (GdkScreen *screen,
69+@@ -2743,8 +2744,13 @@ empathy_accounts_dialog_show_application (GdkScreen *screen,
70+ gboolean hidden)
71+ {
72+ #ifdef HAVE_UOA
73+- launch_uoa_panel (selected_account, if_needed, hidden);
74+-#else
75++ if (!g_strcmp0 (g_getenv ("XDG_CURRENT_DESKTOP"), "Unity")) {
76++ launch_uoa_panel (selected_account, if_needed, hidden);
77++ return;
78++ }
79++#endif
80++
81++#ifdef HAVE_GOA
82+ launch_empathy_accounts (selected_account, if_needed, hidden);
83+ #endif
84+ }
85+--
86+1.8.3.2
87+
88+

Subscribers

People subscribed via source and target branches