Merge lp:~darkxst/casper/ubuntu-gnome-casper-tweaks into lp:ubuntu/quantal/casper

Proposed by Tim on 2012-10-03
Status: Superseded
Proposed branch: lp:~darkxst/casper/ubuntu-gnome-casper-tweaks
Merge into: lp:ubuntu/quantal/casper
Diff against target: 74 lines (+51/-0)
3 files modified
debian/changelog (+7/-0)
scripts/casper-bottom/16gdmnopasswd (+43/-0)
scripts/casper-bottom/25adduser (+1/-0)
To merge this branch: bzr merge lp:~darkxst/casper/ubuntu-gnome-casper-tweaks
Reviewer Review Type Date Requested Status
Stéphane Graber 2012-10-03 Needs Fixing on 2012-10-03
Review via email: mp+127634@code.launchpad.net

This proposal supersedes a proposal from 2012-10-03.

This proposal has been superseded by a proposal from 2012-10-03.

Description of the Change

A couple more casper tweaks are required for the Ubuntu GNOME Remix Live CD

- Add a new script to remove the password dialog from gdm, for the live user (who doesnt have a password).
- add ubiquity to gnome-shell favourites.

To post a comment you must log in.
Stéphane Graber (stgraber) wrote :

The change looks reasonable, however it doesn't account for the fact that you can boot the system multiple time when using casper with persistent storage, in such case it looks like you'll be generating invalid javascript (by adding an extra line every boot) and will be appending an extra ubiquity at every boot too.

review: Needs Fixing
1087. By Tim on 2012-10-03

Don't allow recursive matching

1088. By Tim on 2012-10-03

move override to 22desktop_settings.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-10-02 22:13:38 +0000
3+++ debian/changelog 2012-10-03 05:46:21 +0000
4@@ -1,3 +1,10 @@
5+casper (1.327) UNRELEASED; urgency=low
6+
7+ * add gnome-shell favorites tweak to 25adduser
8+ * Add 16gdmnopasswd script, removes gdm password dialog for live user.
9+
10+ -- Tim Lunn <tim@feathertop.org> Wed, 03 Oct 2012 15:42:07 +1000
11+
12 casper (1.326) quantal; urgency=low
13
14 * 22desktop_settings:
15
16=== added file 'scripts/casper-bottom/16gdmnopasswd'
17--- scripts/casper-bottom/16gdmnopasswd 1970-01-01 00:00:00 +0000
18+++ scripts/casper-bottom/16gdmnopasswd 2012-10-03 05:46:21 +0000
19@@ -0,0 +1,43 @@
20+#!/bin/sh
21+
22+PREREQ=""
23+DESCRIPTION="Setting up automatic login..."
24+
25+prereqs()
26+{
27+ echo "$PREREQ"
28+}
29+
30+case $1 in
31+# get pre-requisites
32+prereqs)
33+ prereqs
34+ exit 0
35+ ;;
36+esac
37+
38+. /scripts/casper-functions
39+
40+log_begin_msg "$DESCRIPTION"
41+
42+STRING1=" if (this._userManager.list_users().length > 2 || !(this._userManager.get_user('ubuntu')))\n \
43+ return GdmUtil.fadeInActor(this._promptLabel);\n \
44+ else\n \
45+ this._promptLabel.hide();"
46+STRING2=" if (this._userManager.list_users().length > 2 || !(this._userManager.get_user('ubuntu')))\n \
47+ return GdmUtil.fadeInActor(this._promptEntry);\n \
48+ else\n \
49+ this._promptEntry.hide();"
50+
51+GDMLoginFile=/root/usr/share/gnome-shell/js/gdm/loginDialog.js
52+
53+if [ -f $GDMLoginFile ]; then
54+ # Configure GDM autologin
55+
56+ sed -i -e "s/^.*return GdmUtil.fadeInActor(this._promptLabel);\$/$STRING1/" \
57+ -e "s/^.*return GdmUtil.fadeInActor(this._promptEntry);\$/$STRING2/" \
58+ $GDMLoginFile
59+fi
60+
61+
62+log_end_msg
63
64=== modified file 'scripts/casper-bottom/25adduser'
65--- scripts/casper-bottom/25adduser 2012-10-02 15:29:21 +0000
66+++ scripts/casper-bottom/25adduser 2012-10-03 05:46:21 +0000
67@@ -100,6 +100,7 @@
68 #GDM
69 if [ -d /root/etc/gdm ]; then
70 sed -i '/^[UG]ID_MIN/s/\<1000$/ 999/' /root/etc/login.defs
71+ sed -i "s/'epiphany.desktop',/'ubiquity-gtkui.desktop', 'epiphany.desktop',/" /root/usr/share/glib-2.0/schemas/10_gnome-shell.gschema.override
72 fi
73
74 #Kubuntu

Subscribers

People subscribed via source and target branches

to all changes: