Merge lp:~darkmuggle-deactivatedaccount/ubuntu/quantal/ssl-cert/fdqn.lp1004682 into lp:ubuntu/quantal/ssl-cert

Proposed by Ben Howard
Status: Merged
Merge reported by: Ben Howard
Merged at revision: not available
Proposed branch: lp:~darkmuggle-deactivatedaccount/ubuntu/quantal/ssl-cert/fdqn.lp1004682
Merge into: lp:ubuntu/quantal/ssl-cert
Diff against target: 30 lines (+9/-2)
2 files modified
debian/changelog (+7/-0)
make-ssl-cert (+2/-2)
To merge this branch: bzr merge lp:~darkmuggle-deactivatedaccount/ubuntu/quantal/ssl-cert/fdqn.lp1004682
Reviewer Review Type Date Requested Status
Scott Moser Approve
Ubuntu branches Pending
Review via email: mp+107473@code.launchpad.net

Description of the change

When the FQDN is longer than 64 characters, fallback to the short hostname.

Currently this prevents hosts with greater than 63 character from installing Apache on Natty and later.

To post a comment you must log in.
15. By Ben Howard

If fully qualified domain name is longer than 64 characters, use the
short hostname. (LP: 1004682)

Revision history for this message
Scott Moser (smoser) wrote :

I'll upload. Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-12-12 14:35:29 +0000
3+++ debian/changelog 2012-05-25 20:40:24 +0000
4@@ -1,3 +1,10 @@
5+ssl-cert (1.0.28ubuntu1) UNRELEASED; urgency=low
6+
7+ * If fully qualified domain name is longer than 64 characters, use the
8+ short hostname. (LP: 1004682)
9+
10+ -- Ben Howard <ben.howard@ubuntu.com> Fri, 25 May 2012 14:37:13 -0600
11+
12 ssl-cert (1.0.28) unstable; urgency=low
13
14 * Add Danish translation, thanks to Joe Hansen. Closes: #606736
15
16=== modified file 'make-ssl-cert'
17--- make-ssl-cert 2010-08-08 23:15:53 +0000
18+++ make-ssl-cert 2012-05-25 20:40:24 +0000
19@@ -30,9 +30,9 @@
20 }
21
22 make_snakeoil() {
23- if ! HostName="$(hostname -f)" ; then
24+ if ! { HostName="$(hostname -f)" && [ ${#HostName} -lt 64 ]; }; then
25 HostName="$(hostname)"
26- echo make-ssl-cert: Could not get FQDN, using \"$HostName\".
27+ echo make-ssl-cert: Could not get or use FQDN, using \"$HostName\".
28 echo make-ssl-cert: You may want to fix your /etc/hosts and/or DNS setup and run
29 echo make-ssl-cert: 'make-ssl-cert generate-default-snakeoil --force-overwrite'
30 echo make-ssl-cert: again.

Subscribers

People subscribed via source and target branches

to all changes: