Merge lp:~darkmuggle-deactivatedaccount/ubuntu/oneiric/munin/oneiric into lp:ubuntu/oneiric/munin

[Ben Howard]

debian/munin-node.upstart: corrected upstart start level (LP: #820669)

[James Page (james-page)]

Hi Ben

Thanks for taking the time to prep this merge proposal.

I have a couple of comments:

1) The changelog entry refers to the wrong bug report - please can you update.

2) Detail of entry - it would be good if you could comment on what the change resolves and well as the actual detail of the change.

I think that in this case its about ensuring that the service starts on all appropriate run-level transitions - but the comment should really reflect that so other dev's can see why the change was made without going to launchpad.

Thanks

James

review: Needs Fixing

[Marc Deslauriers (mdeslaur)]

Could you please retarget this to the version that's currently in Precise, and add the appropriate description to the changelog as requested? Thanks.

review: Needs Fixing

[Martin Pitt (pitti)]

Please set back status to "review" when done. Thanks!

Unmerged revisions

38. By Ben Howard on 2011-09-19

debian/munin-node.upstart: corrected upstart start level (LP: #820669)

=== modified file 'debian/changelog'
--- debian/changelog	2011-04-05 14:57:44 +0000
+++ debian/changelog	2011-09-19 20:59:24 +0000
@@ -1,3 +1,9 @@
+munin (1.4.5-3ubuntu5) oneiric; urgency=medium
+
+  * debian/munin-node.upstart: corrected upstart start level (LP: #820669)
+
+ -- Ben Howard <[e-mail]>  Mon, 19 Sep 2011 14:52:29 -0600
+
 munin (1.4.5-3ubuntu4) natty; urgency=low
 
   * debian/patches/upstream_bug_1009.patch: Backport

=== modified file 'debian/munin-node.upstart'
--- debian/munin-node.upstart	2010-03-20 07:22:06 +0000
+++ debian/munin-node.upstart	2011-09-19 20:59:24 +0000
@@ -3,7 +3,7 @@
 description "munin-node"
 author "Chuck Short <[e-mail]>"
 
-start on (filesystem and net-device-up IFACE=lo)
+start on runlevel [2345]
 stop on runlevel [!2345]
 
 env DAEMON=/usr/sbin/munin-node