Merge ~darinmiller/ka:master into ka:master
Proposed by
Darin Miller
on 2017-04-29
| Status: | Merged |
|---|---|
| Merged at revision: | 02c2c37623b9bf18a7826f199950ea4516094bdf |
| Proposed branch: | ~darinmiller/ka:master |
| Merge into: | ka:master |
| Diff against target: |
23 lines (+6/-1) 1 file modified
lib/git_checks.py (+6/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Kubuntu Packagers | 2017-04-29 | Pending | |
|
Review via email:
|
|||
Description of the Change
Fixed git_checks.py to fail gracefully on failed git assignment
To post a comment you must log in.

Hi, the change seems good, however, apparently there's another place to put a try-except:
user@host:/tmp$ uploadsource santa/kubuntu- automation/ uploadsource" , line 54, in <module> edGitChanges( ) santa/kubuntu- automation/ lib/git_ checks. py", line 50, in checkUnpushedGi tChanges python3/ dist-packages/ git/repo/ base.py" , line 168, in __init__ itoryError( epath) InvalidGitRepos itoryError: /tmp
Traceback (most recent call last):
File "/home/
checkUnpush
File "/home/
git_repo = Repo('.')
File "/usr/lib/
raise InvalidGitRepos
git.exc.