Merge lp:~danrabbit/egtk/progress-text into lp:egtk/1.0

Proposed by Daniel Fore
Status: Merged
Merged at revision: 541
Proposed branch: lp:~danrabbit/egtk/progress-text
Merge into: lp:egtk/1.0
Diff against target: 34 lines (+2/-5)
2 files modified
gtk-3.0/gtk-widgets.css (+2/-4)
gtk-3.0/progressbar.css (+0/-1)
To merge this branch: bzr merge lp:~danrabbit/egtk/progress-text
Reviewer Review Type Date Requested Status
Daniel Fore Approve
Cassidy James Blaede Pending
Review via email: mp+113875@code.launchpad.net

This proposal supersedes a proposal from 2012-06-15.

Description of the change

Makes text more readable when it's placed on top of a progressbar (such as in Midori's download sidebar).

Should test with selected and unselected states as well as various states of progressbar fill.

To post a comment you must log in.
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote : Posted in a previous version of this proposal

Text is black-on-blue when unselected and partially filled. Otherwise it's white-on-blue, which is more readable.

review: Needs Fixing
Revision history for this message
Daniel Fore (danrabbit) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gtk-3.0/gtk-widgets.css'
2--- gtk-3.0/gtk-widgets.css 2012-07-06 03:36:03 +0000
3+++ gtk-3.0/gtk-widgets.css 2012-07-08 20:57:20 +0000
4@@ -229,8 +229,7 @@
5 .menubar *:prelight,
6 .menu *:active,
7 .menu *:prelight,
8-.progressbar row:selected,
9-.progressbar row:selected:focused,
10+.progressbar row,
11 .sidebar.view:selected,
12 .tooltip *,
13 GtkInfoBar *,
14@@ -243,8 +242,7 @@
15 .menubar.menuitem:prelight,
16 .menu *:active,
17 .menu *:prelight,
18-.progressbar row:selected,
19-.progressbar row:selected:focused,
20+.progressbar row,
21 .sidebar.view:selected,
22 .tooltip,
23 GtkInfoBar,
24
25=== modified file 'gtk-3.0/progressbar.css'
26--- gtk-3.0/progressbar.css 2012-06-15 22:02:13 +0000
27+++ gtk-3.0/progressbar.css 2012-07-08 20:57:20 +0000
28@@ -43,7 +43,6 @@
29 -unico-inner-stroke-color: alpha (#fff, 0.0);
30 }
31
32-
33 .progressbar row,
34 .progressbar row:hover {
35

Subscribers

People subscribed via source and target branches

to all changes: