Merge lp:~dano6/podbird/podbird into lp:podbird

[Daniel Kutka]

Fix performance issues

Based on feedback from https://forums.ubports.com/topic/4299/podbird-reignited/96 and Telegram group there is a regression on low end phones using QT 5.12, when ActivityIndicator was causing performance issues, despite not being visible (property running and visible was true). This indicator is not much necassary, it was visible only before adding a first podcast.

[Michael Sheldon (michael-sheldon)]

Looks good, thanks!

review: Approve

[lp:~dano6/podbird/podbird]

217. By Michael Sheldon on 2021-05-25

Merge from lp:~dano6/podbird/podbird

=== modified file 'app/podbird.qml'
--- app/podbird.qml	2021-01-12 21:16:11 +0000
+++ app/podbird.qml	2021-05-17 14:58:46 +0000
@@ -25,6 +25,7 @@
 import QtQuick.LocalStorage 2.0
 import Ubuntu.DownloadManager 1.2
 import QtSystemInfo 5.5
+import Ubuntu.Content 1.3
 import "ui"
 import "themes" as Themes
 import "podcasts.js" as Podcasts
@@ -70,7 +71,6 @@
             episodesUpdating = true;
             Podcasts.updateEpisodes(refreshModels)
         }
-        loadingIndicator.opacity = 0
         // Only perform cleanup of old episodes once a day
         if (Math.floor((today - settings.lastCheck)/86400000) >= 1 && settings.retentionDays !== -1) {
             Podcasts.cleanUp(today, settings.retentionDays)
@@ -529,21 +529,4 @@
             }
         ]
     }
-
-    Rectangle {
-        id: loadingIndicator
-        color: podbird.appTheme.background
-        anchors.fill: parent
-
-        ActivityIndicator {
-            anchors.centerIn: parent
-            running: true
-        }
-
-        Behavior on opacity {
-            UbuntuNumberAnimation {
-            }
-        }
-    }
-
 }

=== modified file 'app/ui/SearchPage.qml'
--- app/ui/SearchPage.qml	2020-07-07 15:59:00 +0000
+++ app/ui/SearchPage.qml	2021-05-17 14:58:46 +0000
@@ -500,7 +500,7 @@
         text: i18n.tr("Importing podcasts...")
 
         ActivityIndicator {
-            running: true
+            running: parent.visible
         }
 
         ProgressBar {