Merge lp:~dano6/podbird/podbird into lp:podbird

Proposed by Daniel Kutka
Status: Merged
Merged at revision: 213
Proposed branch: lp:~dano6/podbird/podbird
Merge into: lp:podbird
Diff against target: 20 lines (+2/-1)
1 file modified
backend/modules/Podbird/filemanager.cpp (+2/-1)
To merge this branch: bzr merge lp:~dano6/podbird/podbird
Reviewer Review Type Date Requested Status
Michael Sheldon Approve
Review via email: mp+392611@code.launchpad.net

Description of the change

This should fix that occasionally you was unable to play some downloaded episodes. Issue was that sometimes there were weird characters in path string due bad text encoding

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Awesome, thanks very much!

review: Approve
lp:~dano6/podbird/podbird updated
213. By Michael Sheldon on 2020-10-25

Merge dano6's changes to fix unplayable downloads

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'backend/modules/Podbird/filemanager.cpp'
2--- backend/modules/Podbird/filemanager.cpp 2017-01-01 14:28:51 +0000
3+++ backend/modules/Podbird/filemanager.cpp 2020-10-21 15:27:37 +0000
4@@ -19,6 +19,7 @@
5 #include <QFile>
6 #include <QDebug>
7 #include <QDir>
8+#include <QUrl>
9 #include <QStandardPaths>
10
11 #include "filemanager.h"
12@@ -56,7 +57,7 @@
13 QString filePath;
14 int attempts = 0;
15 do {
16- filePath = m_podcastDir + QDir::separator() + fi.fileName();
17+ filePath = m_podcastDir + QDir::separator() + QUrl::fromPercentEncoding(fi.fileName().toUtf8());
18 if (attempts > 0) {
19 filePath += "." + QString::number(attempts);
20 }

Subscribers

People subscribed via source and target branches

to status/vote changes: