Merge lp:~dannf/ubuntu/trusty/base-installer/arm64+calxeda-subarches into lp:ubuntu/trusty/base-installer

Proposed by dann frazier
Status: Rejected
Rejected by: Colin Watson
Proposed branch: lp:~dannf/ubuntu/trusty/base-installer/arm64+calxeda-subarches
Merge into: lp:ubuntu/trusty/base-installer
Diff against target: 51 lines (+28/-0)
3 files modified
debian/changelog (+9/-0)
kernel/arm64.sh (+13/-0)
kernel/armel.sh (+6/-0)
To merge this branch: bzr merge lp:~dannf/ubuntu/trusty/base-installer/arm64+calxeda-subarches
Reviewer Review Type Date Requested Status
Colin Watson Disapprove
Ubuntu branches Pending
Review via email: mp+199977@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

I believe the highbank/midway changes in libd-i didn't actually work out that way (they seem to be generic now), so rejecting this in favour of https://code.launchpad.net/~dannf/ubuntu/trusty/base-installer/arm64/+merge/199972. Let me know if that's wrong.

review: Disapprove

Unmerged revisions

108. By dann frazier

libdebian-installer is being changed to expose the "highbank" and "midway"
subarchitectures instead of bucketing them as "generic" and "generic-lpae".
Add kernel detection support for them.

107. By dann frazier

Add arm64 kernel detection (LP: #1263756)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-09-10 15:15:59 +0000
3+++ debian/changelog 2013-12-23 21:01:15 +0000
4@@ -1,3 +1,12 @@
5+base-installer (1.122ubuntu18) UNRELEASED; urgency=low
6+
7+ * Add arm64 kernel detection (LP: #1263756)
8+ * libdebian-installer is being changed to expose the "highbank" and "midway"
9+ subarchitectures instead of bucketing them as "generic" and "generic-lpae".
10+ Add kernel detection support for them.
11+
12+ -- dann frazier <dann.frazier@canonical.com> Mon, 23 Dec 2013 12:41:34 -0700
13+
14 base-installer (1.122ubuntu17) saucy; urgency=low
15
16 * Add generic-lpae the the allowed list of subarches in armhf/armel.
17
18=== added file 'kernel/arm64.sh'
19--- kernel/arm64.sh 1970-01-01 00:00:00 +0000
20+++ kernel/arm64.sh 2013-12-23 21:01:15 +0000
21@@ -0,0 +1,13 @@
22+arch_get_kernel_flavour () {
23+ echo "$MACHINE"
24+ return 0
25+}
26+
27+arch_check_usable_kernel () {
28+ return 0
29+}
30+
31+arch_get_kernel () {
32+ echo "linux-generic"
33+ echo "linux-image-generic"
34+}
35
36=== modified file 'kernel/armel.sh'
37--- kernel/armel.sh 2013-09-10 15:15:59 +0000
38+++ kernel/armel.sh 2013-12-23 21:01:15 +0000
39@@ -8,6 +8,12 @@
40 # easier to offer unofficial support from a private apt-archive
41 echo "ads"
42 return 0 ;;
43+ highbank)
44+ echo "generic"
45+ return 0 ;;
46+ midway)
47+ echo "generic-lpae"
48+ return 0 ;;
49 *)
50 warning "Unknown $ARCH subarchitecture '$SUBARCH'."
51 return 1 ;;

Subscribers

People subscribed via source and target branches

to all changes: