Merge ~dannf/ubuntu/+source/nova:lp1623871-y into ~ubuntu-server-dev/ubuntu/+source/nova:master

Proposed by dann frazier
Status: Merged
Merged at revision: 1ba6692828528dc560b728a3ccbe98ffe791ab80
Proposed branch: ~dannf/ubuntu/+source/nova:lp1623871-y
Merge into: ~ubuntu-server-dev/ubuntu/+source/nova:master
Diff against target: 85 lines (+63/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/libvirt-add-hugepages-support-for-arm64.patch (+56/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Ubuntu Server Developers Pending
Review via email: mp+307230@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 9553a0b..ad811a0 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+nova (2:14.0.0~rc2-0ubuntu3) UNRELEASED; urgency=medium
7+
8+ * d/p/libvirt-add-hugepages-support-for-arm64.patch: (LP: #1623871).
9+
10+ -- dann frazier <dannf.frazier@canonical.com> Wed, 05 Oct 2016 15:23:36 -0600
11+
12 nova (2:14.0.0~rc2-0ubuntu2) yakkety; urgency=medium
13
14 * d/t/nova-compute-daemons: Bump timeout for pid detection
15diff --git a/debian/patches/libvirt-add-hugepages-support-for-arm64.patch b/debian/patches/libvirt-add-hugepages-support-for-arm64.patch
16new file mode 100644
17index 0000000..ecb2aa9
18--- /dev/null
19+++ b/debian/patches/libvirt-add-hugepages-support-for-arm64.patch
20@@ -0,0 +1,56 @@
21+From 190990e7c864deb7034d857630f34f6b26ceba4a Mon Sep 17 00:00:00 2001
22+From: VeenaSL <mveenasl@gmail.com>
23+Date: Mon, 19 Sep 2016 13:36:53 +0530
24+Subject: [PATCH] Adding hugepage and NUMA support check for aarch64
25+
26+Nova ignores aarch64 while verifying for hugepage and NUMA support.
27+AARCH64 also supports hugepage and NUMA on the same libvirt versions as of x86.
28+Hence adding this chek for aarch64 also.
29+
30+Change-Id: I7b5ae1dbdca4fdd0aee2eefd4099c4c4953b609a
31+Closes-bug: #1623871
32+
33+[dannf: Also add AARCH64 to hugepages arches in test_driver.py]
34+
35+Origin: https://review.openstack.org/#/c/372304/
36+Bug: http://bugs.launchpad.net/bugs/1623871
37+Bug-Ubuntu: http://bugs.launchpad.net/bugs/1623871
38+
39+Index: nova-14.0.0~rc1/nova/virt/libvirt/driver.py
40+===================================================================
41+--- nova-14.0.0~rc1.orig/nova/virt/libvirt/driver.py
42++++ nova-14.0.0~rc1/nova/virt/libvirt/driver.py
43+@@ -5108,7 +5108,8 @@ class LibvirtDriver(driver.ComputeDriver
44+ self._bad_libvirt_numa_version_warn = True
45+ return False
46+
47+- support_matrix = {(arch.I686, arch.X86_64): MIN_LIBVIRT_NUMA_VERSION,
48++ support_matrix = {(arch.I686, arch.X86_64,
49++ arch.AARCH64): MIN_LIBVIRT_NUMA_VERSION,
50+ (arch.PPC64,
51+ arch.PPC64LE): MIN_LIBVIRT_NUMA_VERSION_PPC}
52+ caps = self._host.get_capabilities()
53+@@ -5124,7 +5125,8 @@ class LibvirtDriver(driver.ComputeDriver
54+ def _has_hugepage_support(self):
55+ # This means that the host can support multiple values for the size
56+ # field in LibvirtConfigGuestMemoryBackingPage
57+- supported_archs = [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64]
58++ supported_archs = [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64,
59++ arch.AARCH64]
60+ caps = self._host.get_capabilities()
61+ return ((caps.host.cpu.arch in supported_archs) and
62+ self._host.has_min_version(MIN_LIBVIRT_HUGEPAGE_VERSION,
63+Index: nova-14.0.0~rc1/nova/virt/libvirt/driver.py
64+===================================================================
65+--- nova-14.0.0~rc1.orig/nova/tests/unit/virt/libvirt/test_driver.py
66++++ nova-14.0.0~rc1/nova/tests/unit/virt/libvirt/test_driver.py
67+@@ -2910,7 +2910,8 @@ class LibvirtConnTestCase(test.NoDBTestCase):
68+ return_value=True)
69+ @mock.patch.object(host.Host, "get_capabilities")
70+ def test_does_want_hugepages(self, mock_caps, mock_hp, mock_numa):
71+- for each_arch in [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64]:
72++ for each_arch in [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64,
73++ arch.AARCH64]:
74+ self._test_does_want_hugepages(
75+ mock_caps, mock_hp, mock_numa, each_arch)
76+
77diff --git a/debian/patches/series b/debian/patches/series
78index 45452f1..ab64803 100644
79--- a/debian/patches/series
80+++ b/debian/patches/series
81@@ -1,3 +1,4 @@
82 # Ubuntu specific patches below here. Note these can be dropped eventually.
83 arm-console-patch.patch
84 wsgi-intercept.patch
85+libvirt-add-hugepages-support-for-arm64.patch

Subscribers

People subscribed via source and target branches