Merge ~dannf/plainbox-provider-checkbox:lp1751167 into plainbox-provider-checkbox:master

Proposed by dann frazier
Status: Merged
Approved by: Jeff Lane 
Approved revision: 3b70e683c1aaece7e535095f4fe162c2838fd22c
Merged at revision: e7bfd5fad6af67d7c4f80147126324d73775acad
Proposed branch: ~dannf/plainbox-provider-checkbox:lp1751167
Merge into: plainbox-provider-checkbox:master
Diff against target: 13 lines (+1/-1)
1 file modified
bin/disk_stress_ng (+1/-1)
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+338597@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Good catch... I wonder why this never popped up before, because the same should be true on any HDD with multiple partitions:

ubuntu@xwing:~$ sudo parted -l
Model: LSI MR9260-8i (scsi)
Disk /dev/sda: 1000GB
Sector size (logical/physical): 512B/512B
Partition Table: gpt
Disk Flags:

Number Start End Size File system Name Flags
 1 1049kB 538MB 537MB fat32 boot, esp
 2 538MB 1000GB 999GB ext4

Maybe just lucky how the partitions are presented... either way, this works.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/disk_stress_ng b/bin/disk_stress_ng
2index 0b5de83..df5694e 100755
3--- a/bin/disk_stress_ng
4+++ b/bin/disk_stress_ng
5@@ -121,7 +121,7 @@ find_largest_partition() {
6 exit 1
7 fi
8 local blkid_info=$(blkid -s TYPE $part_location | grep -E ext2\|ext3\|ext4\|xfs\|jfs\|btrfs\|LVM2_member)
9- if [ "$part_size" > "$largest_size" ] && [ -n "$blkid_info" ] ; then
10+ if [ "$part_size" -gt "$largest_size" ] && [ -n "$blkid_info" ] ; then
11 if [[ "$blkid_info" =~ .*LVM2_member.* ]] ; then
12 find_largest_lv
13 else

Subscribers

People subscribed via source and target branches