Merge ~dannf/plainbox-provider-checkbox:lp1698164 into plainbox-provider-checkbox:master

Proposed by dann frazier
Status: Merged
Approved by: Sylvain Pineau
Approved revision: d78b4dcd3d5b6d43b993f4cceff43943e5adda2a
Merged at revision: 174dbf09287ffecc3ba139bb830dc2ac2821689d
Proposed branch: ~dannf/plainbox-provider-checkbox:lp1698164
Merge into: plainbox-provider-checkbox:master
Diff against target: 13 lines (+1/-1)
1 file modified
jobs/cpu.txt.in (+1/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
dann frazier (community) Needs Resubmitting
Devices Certification Bot Needs Fixing
Review via email: mp+326547@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

I tried to merge it but there are some problems. Typically you want to merge or rebase and try again.

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[trusty] starting container
[trusty] (timing) 0.08user 0.01system 0:05.26elapsed 1%CPU (0avgtext+0avgdata 16696maxresident)k
[trusty] (timing) 0inputs+32outputs (0major+5434minor)pagefaults 0swaps
[trusty] provisioning container
[trusty] (timing) 32.33user 12.27system 1:17.64elapsed 57%CPU (0avgtext+0avgdata 67468maxresident)k
[trusty] (timing) 0inputs+1566760outputs (16major+1123902minor)pagefaults 0swaps
[trusty-testing] Starting tests...
Found a test script: ./requirements/container-tests-provider-checkbox
[trusty-testing] container-tests-provider-checkbox: FAIL
[trusty-testing] stdout: https://paste.ubuntu.com/25037812/
[trusty-testing] stderr: https://paste.ubuntu.com/25037813/
[trusty-testing] (timing) Command exited with non-zero status 1
[trusty-testing] (timing) 8.82user 1.34system 0:15.11elapsed 67%CPU (0avgtext+0avgdata 49572maxresident)k
[trusty-testing] (timing) 0inputs+100984outputs (0major+91849minor)pagefaults 0swaps
[trusty-testing] Fixing file permissions in source directory
[trusty-testing] Destroying container
Name: trusty-testing
State: STOPPED
[xenial] starting container
[xenial] (timing) 0.06user 0.03system 0:05.26elapsed 1%CPU (0avgtext+0avgdata 16900maxresident)k
[xenial] (timing) 0inputs+32outputs (0major+5407minor)pagefaults 0swaps
[xenial] provisioning container
[xenial] (timing) 64.83user 18.42system 2:06.96elapsed 65%CPU (0avgtext+0avgdata 107788maxresident)k
[xenial] (timing) 24inputs+2536744outputs (2major+1998441minor)pagefaults 0swaps
[xenial-testing] Starting tests...
Found a test script: ./requirements/container-tests-provider-checkbox
[xenial-testing] container-tests-provider-checkbox: FAIL
[xenial-testing] stdout: https://paste.ubuntu.com/25037818/
[xenial-testing] stderr: https://paste.ubuntu.com/25037819/
[xenial-testing] (timing) Command exited with non-zero status 1
[xenial-testing] (timing) 11.00user 1.14system 0:14.34elapsed 84%CPU (0avgtext+0avgdata 75384maxresident)k
[xenial-testing] (timing) 0inputs+100992outputs (0major+95310minor)pagefaults 0swaps
[xenial-testing] Fixing file permissions in source directory
[xenial-testing] Destroying container
Name: xenial-testing
State: STOPPED

review: Needs Fixing
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

@Dann, could you please apply your fix on top of recent master?

review: Needs Fixing
Revision history for this message
dann frazier (dannf) wrote :

Rebased on top of current master.

review: Needs Resubmitting
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

thank you Dann

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/cpu.txt.in b/jobs/cpu.txt.in
2index 76ece21..bdea273 100644
3--- a/jobs/cpu.txt.in
4+++ b/jobs/cpu.txt.in
5@@ -34,7 +34,7 @@ id: cpu/maxfreq_test
6 estimated_duration: 0.6
7 requires:
8 package.name == 'fwts' or executable.name == 'fwts'
9- cpuinfo.platform in ("i386", "x86_64", "aarch64")
10+ cpuinfo.platform in ("i386", "x86_64")
11 user: root
12 environ: LD_LIBRARY_PATH SNAP
13 command:

Subscribers

People subscribed via source and target branches