Merge ~dannf/plainbox-provider-checkbox/+git/lp1940112:master into ~checkbox-dev/plainbox-provider-checkbox/+git/packaging:master

[dann frazier]

[Taihsiang Ho (tai271828)]

Per discussion of the sprint today, I will provide more "how to test and how the test result is" to help the checkbox developer team easier to review the merge proposal.

[Sylvain Pineau (sylvain-pineau)]

+1

the package is available in ubuntu archives since Bionic
https://packages.ubuntu.com/bionic/qemu-efi-aarch64

review: Approve

[dann frazier (dannf)]

Thanks @Sylvain! What is the next step towards merging?

[Taihsiang Ho (tai271828)]

I have verified this merge proposal could bring up the dependency installation specific to 18.04 on arm64, and no regression was found on the other releases and arch.

= Test results =
amd64 20.04 - ok (no regression)
amd64 18.04 - ok (no regression)

arm64 20.04 - ok (no regression)
arm64 18.04 - ok (install my deb will install qemu arm64)

= Test flow =
1. Build plainbox-provider-checkbox for the matrix combination of 18.04/20.04 and amd64/arm64
2. Install the package we built at step1
3. Redo the steps described in the corresponding bug report https://bugs.launchpad.net/plainbox-provider-checkbox/+bug/1940112 to get the test results to see if there is regression[1] or issue fixup[2].

[1] The test job, "com.canonical.certification::virtualization/kvm_check_vm", should always pass after installing plainbox-provider-checkbox we built (except 18.04 arm64)

[2] For 18.04 arm64,
- before installing plainbox-provider-checkbox we built: test job fails.
- after: when installing plainbox-provider-checkbox via apt, apt will remind you to install the qemu-efi-aarch64 debs because of the dependency:

Depends: plainbox-provider-resource-generic (>= 0.25), python3, python3-checkbox-support (>= 0.25), python3-zbar, python3-pil, python3-pyqrcode, nvme-cli, uuid-runtime, python3-psutil, kmod, python3-natsort, python3-debian, util-linux, hwloc, debsums, ntpdate, net-tools, iperf3, evemu-tools, python3-serial, stress-ng (>= 0.04), jq, libjson-xs-perl, python3-evdev, qemu-efi-aarch64, libasound2 (>= 1.0.16), libc6 (>= 2.17), libgcc1 (>= 1:4.0), libstdc++6 (>= 6)

Move forward the installation process could make the test job, "com.canonical.certification::virtualization/kvm_check_vm", pass.

[Sylvain Pineau (sylvain-pineau)]

OMG, I didn't spotted that you were targeting the packaging repo, that's bad since the code there is actually a copy of the master source tree and git-dpm is using it to compute the patches.

I'm going to revert this patch and repropose it against the right repo

review: Needs Fixing

diff --git a/units/virtualization/packaging.pxu b/units/virtualization/packaging.pxu
new file mode 100644
index 0000000..26922ea
--- /dev/null
+++ b/units/virtualization/packaging.pxu
@@ -0,0 +1,4 @@
+# qemu-efi-aarch64 provides the firmware uvtool needs for arm64 LP: #1940112
+unit: packaging meta-data
+os-id: debian
+Depends: qemu-efi-aarch64 [arm64]