Merge lp:~dannf/flash-kernel/armadaxp into lp:ubuntu/quantal/flash-kernel

Proposed by dann frazier on 2012-05-30
Status: Merged
Merge reported by: Oliver Grawert
Merged at revision: not available
Proposed branch: lp:~dannf/flash-kernel/armadaxp
Merge into: lp:ubuntu/quantal/flash-kernel
Diff against target: 77 lines (+23/-1)
5 files modified
README (+1/-0)
db/all.db (+11/-0)
debian/changelog (+7/-0)
debian/control (+1/-1)
debian/flash-kernel-installer.isinstallable (+3/-0)
To merge this branch: bzr merge lp:~dannf/flash-kernel/armadaxp
Reviewer Review Type Date Requested Status
Oliver Grawert Approve on 2012-05-31
Robie Basak Needs Fixing on 2012-05-31
Ubuntu branches 2012-05-30 Pending
Review via email: mp+108070@code.launchpad.net

Description of the Change

This rebases the armadaxp support on top of the new flash-kernel architecture. I've tested it in a quantal install w/ a hacked mirror & things went fine.

I'd like to push these changes into Debian as well - but I think the boot script needs some work first. Low-hanging fruit is to trim the Ubuntu/Canonical references, but I also wonder if the boot.scr (which is what we shipped in precise) works as expected on this platform. It seems to assume that load addresses are preset in the environment, which they don't appear to be on the board I'm using. That probably needs further investigation, but this change is enough to avoid precise->quantal regressions.

To post a comment you must log in.
Robie Basak (racb) wrote :

I think bootscript/bootscr.armadaxp needs to have the mkimage header stripped from the start; it's gone in as a binary, but the others in there are text and presumably flash-kernel runs mkimage on them first. Just strip the first 64 bytes.

review: Needs Fixing
Oliver Grawert (ogra) wrote :

i'll merge this with omitting the binary bits later today

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2012-03-11 14:51:15 +0000
3+++ README 2012-05-30 22:03:17 +0000
4@@ -26,6 +26,7 @@
5 - HP Media Vault mv2120
6 - Intel SS4000-E
7 - Linksys NSLU2
8+ - Marvell Armada XP Development Board (Ubuntu)
9 - Marvell DB-78x00-BP Development Board
10 - Marvell OpenRD-Base
11 - Marvell OpenRD-Client
12
13=== added file 'bootscript/bootscr.armadaxp'
14Binary files bootscript/bootscr.armadaxp 1970-01-01 00:00:00 +0000 and bootscript/bootscr.armadaxp 2012-05-30 22:03:17 +0000 differ
15=== modified file 'db/all.db'
16--- db/all.db 2012-03-10 01:17:09 +0000
17+++ db/all.db 2012-05-30 22:03:17 +0000
18@@ -137,6 +137,17 @@
19 Required-packages: apex-nslu2 nslu2-utils
20 Bootloader-sets-root: no
21
22+Machine: Marvell Armada XP Development Board
23+Kernel-Flavors: armadaxp
24+U-Boot-Kernel-Address: 0x02000000
25+U-Boot-Initrd-Address: 0x20000000
26+U-Boot-Script-Address: 0x1000
27+U-Boot-Script-Name: bootscr.armadaxp
28+Boot-Kernel-Path: /boot/uImage
29+Boot-Initrd-Path: /boot/uInitrd
30+Required-Packages: u-boot-tools
31+Bootloader-sets-root: no
32+
33 Machine: Marvell DB-78x00-BP Development Board
34 U-Boot-Kernel-Address: 0x8000
35 U-Boot-Initrd-Address: 0x0
36
37=== modified file 'debian/changelog'
38--- debian/changelog 2012-03-11 14:51:15 +0000
39+++ debian/changelog 2012-05-30 22:03:17 +0000
40@@ -1,3 +1,10 @@
41+flash-kernel (3.0~rc.4ubuntu1) UNRELEASED; urgency=low
42+
43+ [ dann frazier ]
44+ * Re-add support for Marvell ArmadaXP
45+
46+ -- dann frazier <dann.frazier@canonical.com> Wed, 30 May 2012 15:20:00 -0600
47+
48 flash-kernel (3.0~rc.4) unstable; urgency=low
49
50 * Upload to unstable
51
52=== modified file 'debian/control'
53--- debian/control 2012-03-11 14:51:15 +0000
54+++ debian/control 2012-05-30 22:03:17 +0000
55@@ -29,7 +29,7 @@
56 Priority: standard
57 XC-Package-Type: udeb
58 Architecture: arm armel armeb armhf
59-XB-Subarchitecture: iop32x ixp4xx kirkwood orion5x s3c24xx mx5
60+XB-Subarchitecture: armadaxp iop32x ixp4xx kirkwood orion5x s3c24xx mx5
61 Provides: bootable-system
62 Depends: cdebconf-udeb, installed-base
63 XB-Installer-Menu-Item: 7300
64
65=== modified file 'debian/flash-kernel-installer.isinstallable'
66--- debian/flash-kernel-installer.isinstallable 2012-03-11 14:51:15 +0000
67+++ debian/flash-kernel-installer.isinstallable 2012-05-30 22:03:17 +0000
68@@ -2,6 +2,9 @@
69 set -e
70
71 case "`archdetect`" in
72+ arm*/armadaxp)
73+ exit 0
74+ ;;
75 arm*/iop32x)
76 exit 0
77 ;;

Subscribers

People subscribed via source and target branches