~dannf/charms/+source/scalebot-jenkins:go-stop

Branch merges

Propose for merging

Merged into ~ce-hyperscale/charms/+source/scalebot-jenkins:master at revision 9f1e40ed3b4c54d8ceea9936acc968b6dbc836bc

Taihsiang Ho: Approve on 2021-04-23

dann frazier: Pending requested 2021-04-15

Diff: 103 lines (+24/-6)

1 file modified

reactive/scalebot-jenkins.py (+24/-6)

api

Superseded for merging into ~dannf/charms/+source/scalebot-jenkins:master

dann frazier: Pending requested 2021-04-15

Diff: 1007 lines (+919/-2)

14 files modified

.flake8 (+2/-0)
.pre-commit-config.yaml (+10/-0)
README.devel (+12/-0)
README.md (+92/-0)
actions.yaml (+2/-0)
actions/refreshjobs (+6/-0)
bin/jobsync.py (+100/-0)
bin/pull-and-reload-jobs (+18/-0)
config.yaml (+47/-0)
files/known_hosts.lp (+2/-0)
layer.yaml (+22/-1)
lib/charms/layer/scalebot_jenkins.py (+44/-0)
metadata.yaml (+12/-1)
reactive/scalebot-jenkins.py (+550/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

9f1e40e... by dann frazier on 2021-04-15

Block unnecessary reactions when the charm is stopping

If a user removes the scalebot application (`juju remove-application`), juju
will trigger the stop hook. We provide a stop hook which destroys the lab
controller, freeing up resources in the cloud. However, the charm continues
to react to other events, which can lead to it *re*-bootstrapping a
controller. This can lead to orphaned resources in the cloud.

Introduce a new pair of states[*], "scalebot.go" and "scalebot.stop", which
are intended to be mutually exclusive. The charm will start out and remain
in the "scalebot.go" state until the stop hook is called, at which point
we'll transition to the "scalebot.stop" state. Add guards to prevent
various reactions from executing in "scalebot.stop".

[*] The "state" API has been apparently deprecated for a "flag" API for
    some time. We should switch over to the "flag" API - but I'll leave
    that for another time.

16ed2f5... by dann frazier on 2021-04-15

README.devel: Remind developers to tag the repo after pushing a new charm

e727b57... by Taihsiang Ho on 2021-04-07

Stop supporting Bionic

Bionic has python package dependency issue for scalebot. In the
meantime, the conflict is incompatible with Focal. Instead of supporting
both distrobutions, we decided to stop supporting Bionic and focusing on
Focal.

LP: #1920983 (private bug)

63bf06f... by Taihsiang Ho on 2021-04-07

Fix charm build warning of email information

This commit fixes this warning message:

proof: W: Maintainer format should be "Name <Email>", not
"<email address hidden>"

79a5200... by dann frazier on 2021-03-30

Fix typo and simplify log message

The main goal here is to correct spelling of "bootstrapping", but I also
decided to shorten the message because I'm not sure the second sentence
was adding to the first.

5f7aec1... by dann frazier on 2021-03-30

Fix reference-before-assignment issue

Seen in debug-log:

unit-scalebot-0: 12:01:15 WARNING unit.scalebot/0.stop UnboundLocalError: local variable 'modeldefaultsfile' referenced before assignment
unit-scalebot-0: 12:01:16 ERROR juju.worker.uniter.operation hook "stop" (via explicit, bespoke hook script) failed: exit status 1

fe90de4... by dann frazier on 2021-03-24

Add focal support

This charm deploys fine on Ubuntu 20.04 ('focal'), so designate it to
be a supported series.

5e2ad36... by dann frazier on 2021-03-24

Remove the python3-maas-client dependency

The scalebot-jenkins charm itself does not know anything about MAAS, it is
cloud-agnostic by design. If a specific scalebot config needs to talk to
a MAAS directly, it should install the necessary dependencies itself
(e.g. using scalebot.d/init). python3-maas-client is no longer available
in Ubuntu 20.04 ('focal'), so this is necessary to support that series.

1bd653d... by Taihsiang Ho on 2020-10-08

Merge branch 'mr-remote-lxd' into master

1454aa4... by Taihsiang Ho on 2020-09-30

refactor(config.yaml): rm useless lxd parameters